ament / uncrustify Goto Github PK

View Code? Open in Web Editor NEW

This project forked from uncrustify/uncrustify

1.0 1.0 3.0 8.2 MB

Code beautifier

Home Page: http://uncrustify.sourceforge.net/

uncrustify's People

Contributors

Stargazers

Watchers

Forkers

asirobots firesurfer xr-ament

uncrustify's Issues

Tests occasionally fail when run repeatedly

When the tests for this package are run multiple times, occasionally tests start to fail.
http://ci.ros2.org/job/nightly_win_rep/625/testReport/junit/projectroot/tests/test_uncrustify/ failed on the 20th time with test file 02431 and http://ci.ros2.org/job/nightly_win_rep/629/testReport/junit/projectroot/tests/test_uncrustify/ failed on the 13th time with test file 01021

I've only seen this happen on windows. Given the line at which it fails I would think it's an I/O error and not the linter itself.

Create new repo uncrutify_vendor and deprecate this one

Follow up of #23

Now that recent uncrustify versions have been released in debian we should use upstream where we can and build uncrustify only on platforms that need it

fails to build on Windows in Jenkins

I get this when it try's to upgrade the project file:

http://54.183.26.131:8080/job/ros2_batch_ci_windows/

C:/Jenkins/workspace/ros2_batch_ci_windows/workspace/src/ament/uncrustify/win32/Debug/Uncrustify.exe

         Microsoft Visual Studio 2015 RC Version 14.0.22823.1.
         Copyright (C) Microsoft Corp. All rights reserved.

         The license for Visual Studio has expired.

         The evaluation period for this product has ended.
     5>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(170,5): error MSB6006: "cmd.exe" exited with code 1. [C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\uncrustify\external_uncrustify.vcxproj]
     5>Done Building Project "C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\uncrustify\external_uncrustify.vcxproj" (default targets) -- FAILED.
     3>Done Building Project "C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\uncrustify\external_uncrustify.vcxproj.metaproj" (default targets) -- FAILED.
     2>Done Building Project "C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\uncrustify\ALL_BUILD.vcxproj.metaproj" (default targets) -- FAILED.
     1>Done Building Project "C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\uncrustify\uncrustify.sln" (default targets) -- FAILED.

Build FAILED.

       "C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\uncrustify\uncrustify.sln" (default target) (1) ->
       "C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\uncrustify\external_uncrustify.vcxproj.metaproj" (default target) (3) ->
       "C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\uncrustify\external_uncrustify.vcxproj" (default target) (5) ->
       (CustomBuild target) -> 
         C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(170,5): error MSB6006: "cmd.exe" exited with code 1. [C:\Jenkins\workspace\ros2_batch_ci_windows\workspace\build\uncrustify\external_uncrustify.vcxproj]

    0 Warning(s)
    1 Error(s)

If I use a custom ros2.repos file which excludes this repository it gets further and fails on the know issue about the IDL file, see:

http://54.183.26.131:8080/job/ros2_batch_ci_windows/228/console

This does not pose a problem when running it from a terminal directly on the machine. Even the IDL bug doesn't occur when building from source in the cmd prompt, but that may be due to the fact that I have slightly out-of-date sources. So some reason this is a problem when running under Jenkins. I updated the jenkins slave service to run as the local account, but that didn't help.

This was happening and so I looked to see if there was a newer version. There was so I updated to VS 2015 Community RC, but the issue persisted after upgrading (by uninstalling VS 2015 Ultimate Preview and the installing the new version).

One other thought I had, as a workaround, was to upgrade the solution file and commit it. That might solve the issue for now.

fails to build with missing file

When building on my Trusty VM with ./src/ament/ament_tools/scripts/ament.py build ./src --build-tests:

Process package 'uncrustify' with context:
--------------------------------------------------------------------------------
 source_space => /home/william/ros2_ws/src/ament/uncrustify
  build_space => /home/william/ros2_ws/build/uncrustify
install_space => /home/william/ros2_ws/install
   make_flags => -j4, -l4
  build_tests => True
--------------------------------------------------------------------------------
+++ Building 'uncrustify'
Running cmake because arguments have changed.
==> '. /home/william/ros2_ws/build/uncrustify/ament_cmake__build.sh && /usr/bin/cmake /home/william/ros2_ws/src/ament/uncrustify -DCMAKE_INSTALL_PREFIX=/home/william/ros2_ws/install -DAMENT_ENABLE_TESTING=1' in '/home/william/ros2_ws/build/uncrustify'
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    AMENT_ENABLE_TESTING


-- Build files have been written to: /home/william/ros2_ws/build/uncrustify
==> '. /home/william/ros2_ws/build/uncrustify/ament_cmake__build.sh && /usr/bin/make -j4 -l4' in '/home/william/ros2_ws/build/uncrustify'
Scanning dependencies of target external_uncrustify
[ 12%] Creating directories for 'external_uncrustify'
[ 25%] No download step for 'external_uncrustify'
[ 50%] [ 50%] No patch step for 'external_uncrustify'
No update step for 'external_uncrustify'
[ 62%] Performing configure step for 'external_uncrustify'
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for g++... g++
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking for style of include used by make... GNU
checking dependency style of g++... none
checking for gcc... gcc
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... none
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for inttypes.h... (cached) yes
checking for stdint.h... (cached) yes
checking utime.h usability... yes
checking utime.h presence... yes
checking for utime.h... yes
checking for stdbool.h that conforms to C99... yes
checking for _Bool... yes
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for working memcmp... yes
checking for memset... yes
checking for strcasecmp... yes
checking for strchr... yes
checking for strdup... yes
checking for strerror... yes
checking for strtol... yes
checking for strtoul... yes
checking whether our compiler supports __func__... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating man/Makefile
config.status: creating man/uncrustify.1
config.status: creating src/uncrustify_version.h
config.status: creating src/config.h
config.status: executing depfiles commands
[ 75%] No build step for 'external_uncrustify'
[ 87%] Performing install step for 'external_uncrustify'
Making install in src
Rebuilding token_names.h
sh: 0: Can't open ../make_token_names.sh
make[4]: *** [token_names.h] Error 127
make[3]: *** [install-recursive] Error 1
make[2]: *** [external_uncrustify-prefix/src/external_uncrustify-stamp/external_uncrustify-install] Error 2
make[1]: *** [CMakeFiles/external_uncrustify.dir/all] Error 2
make: *** [all] Error 2

I believe I'm using the latest:

$ cd src/ament/uncrustify && git log -1; cd -
commit b9cd1dc9b73eab61904491bf2a565622b34e5cc4
Author: Dirk Thomas <[email protected]>
Date:   Tue Apr 14 15:34:49 2015 -0700

    add package.xml and CMakeLists.txt

And I've completely cleared my build and install spaces before.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.