Coder Social home page Coder Social logo

Google Cloud Spanner support about dbmate HOT 2 CLOSED

amacneil avatar amacneil commented on May 22, 2024
Google Cloud Spanner support

from dbmate.

Comments (2)

AJCStriker avatar AJCStriker commented on May 22, 2024

Hey @amacneil I would be interested in picking this issue up and submitting a PR.

I took a look at the current drivers but is there anything to keep in mind whilst designing an integration?
In particular clarification about how you view Connection lifecycles would be really helpful?

from dbmate.

amacneil avatar amacneil commented on May 22, 2024

Last time I looked into this, I ran into the issue that dbmate has been designed around an assumption that all drivers will use database/sql, and the spanner driver did not use that. So it would require refactoring the driver interface to remove dependence on database/sql.

Long term I think this is a good direction to take dbmate, but just be aware that to achieve this feature I think you will need to refactor the interface and all other drivers to match the new interface, it won't be a simple case of adding one new driver.

From memory there also might be a problem with the spanner driver not accepting multiple sql statements in one string, so we will need to import a sql parsing library and do our own statement splitting. Again I think this is a nice feature that would benefit all drivers eventually (allowing us to give more helpful error messages, etc), but it adds complexity.

from dbmate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.