dbmate requires each migration to define a down block with '-- migrate:down' when it defined about dbmate

[nolinkspl]

I can create PR if you approve the issue

[DGulshan]

Facing the same issue.

[dossy]

I'm trying to reproduce this issue:

root@c2a4e68d4451:/src# printf -- "-- migrate:up\ncreate table test_issue_472 (id integer);\n-- migrate:down transaction:false\ndrop table test_issue_472;\n" > testdata/db/migrations/472_test_migrate_down_transaction.sql

root@c2a4e68d4451:/src# cat testdata/db/migrations/472_test_migrate_down_transaction.sql 
-- migrate:up
create table test_issue_472 (id integer);
-- migrate:down transaction:false
drop table test_issue_472;

root@c2a4e68d4451:/src# dist/dbmate -u $POSTGRES_TEST_URL -d testdata/db/migrations up
Creating: dbmate_test
Applying: 20151129054053_test_migration.sql
Applying: 20200227231541_test_posts.sql
Applying: 472_test_migrate_down_transaction.sql
Writing: ./db/schema.sql

root@c2a4e68d4451:/src# dist/dbmate -u $POSTGRES_TEST_URL -d testdata/db/migrations down
Rolling back: 472_test_migrate_down_transaction.sql
Writing: ./db/schema.sql

I cannot reproduce the problem with the latest pre-release build:

root@c2a4e68d4451:/src# git --no-pager log --oneline --no-decorate -1
1b5ca4f Bump actions/setup-node from 3 to 4 (#494)

root@c2a4e68d4451:/src# dist/dbmate --version
dbmate version 2.7.0

root@c2a4e68d4451:/src# PGPASSWORD=postgres psql -h postgres -U postgres -tc "select version();" 
 PostgreSQL 10.21 (Debian 10.21-1.pgdg90+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516, 64-bit

Can anyone who is affected by this issue please provide a minimal reproduction migration file that triggers this issue so I can try to reproduce it?

[dossy]

I just noticed that @nolinkspl is on Windows, so this may be a duplicate of #213, which I believe will be fixed by #496.

[dossy]

@nolinkspl Now that v2.8.0 has been released (#497), can you please update to that version and see if you can still reproduce the error?