alphagov / govuk-knowledge-graph-search Goto Github PK

e.g. ?selected-words=justice&search-in-title=true&area=any

• Understand what Cloud Build does with its buckets (currently in the US, not very locked-down)
• Decide when and where to compile sass and run webpack

Maybe some aria attribute

So that you can jump back to the top of the form from the focused Results heading, as well as jump to the actual results from the heading.

Invisible links but that become visible by tabbing

Currently we use the BigQuery tables from the govuk-knowledge-graph in the GCP project.
See https://github.com/alphagov/govuk-knowledge-graph-search/blob/bigquery/bigquery.ts#L13
We should use en environment variable instead so the right BigQuery is used depending on the
project we're on (dev, staging or production).

1. Dates are now shown as objects
2. Withdrawn reason (and possibly other prose) isn't properly escaped

Searching for "The Ministry of Justice" won't show the meta box for it, because "The" isn't in the Organisation's title.
Maybe it would be better to remove "The" (and other common words, like "of" or "for").

But we need to think of cases where it makes a difference first.

Simplifies the CI pipeline as you no longer need to install and run sass and webpack/ts.

Either use variables, which is a bit complicated when you have a varying number of keywords in your query, or sanitize the text inputs: keywords, excluded keywords, links, etc.

See also https://neo4j.com/developer/kb/protecting-against-cypher-injection/

Searching for the keyword "passeport" and dispaying the taxon of results will show the "Brexit" taxon.
However searching for "passeport" and specifying to search in the "Brexit" taxon will return no results.

We need integration and unit tests to avoid breaking anything when making changes.

Simplest would be to ensure the generated cypher queries are the right ones depending on the values of the user-set parameters.

I haven't checked that this is really a bug, but I think contentID must be contentId otherwise it will silently return null.

When more than one metabox we might want to add a disambiguation page

For example, when searching "Uk help and services in Bahrain", the keywords that are actually used are "Uk", "help", "services", "in", and "Bahrain", but the query description says "pages that contain help and services and Bahrain".

The back button currently doesn't always go back to the previous page.