aligrudi / fbpdf Goto Github PK

When you open a document in fbpdf and then try to switch ttys with alt arrow keys, it freezes up the system. I found that I had to force poweroff.

Disclaimer: IANAL, *GPL is horribly controversial and I might be wrong (but I don't think I am)

mupdf is licensed under AGPL terms. Per these terms, any program linking against it (either statically or dynamically), must also be released as AGPL. Releasing fbpdf under BSD is a violation of mupdf license. For this reason, Artifex could extort you or your users into buying a commercial mupdf license.

Now, I'm not sure how to fix it. The 'obvious' solution would be to license fbpdf separately as AGPL. However, I'm not sure if AGPL doesn't require covering other files in the package, particularly the Makefile. Since you have poppler-based fbpdf2, removing fbpdf or splitting it to a separate package may be a better option.

Back again, maybe an install readme with dependencies listed would help etc?
I have done
git clone https://github.com/aligrudi/fbpdf.git
make 2> mybuild.txt
and I get on screen
cc -c -Wall -O2 -I./include fbpdf.c
cc -c -Wall -O2 -I./include mupdf.c
cc -c -Wall -O2 -I./include draw.c
cc -o fbpdf fbpdf.o mupdf.o draw.o -L./lib -lmupdf -lmupdf-third -lmupdf-pkcs7 -lmupdf-threads -lm
and in mybuild.txt
/usr/bin/ld: cannot find -lmupdf-pkcs7
/usr/bin/ld: cannot find -lmupdf-threads
collect2: error: ld returned 1 exit status
make: *** [Makefile:14: fbpdf] Error 1

if I remove -lmupdf-pkcs7 -lmupdf-threads get a load of undefined.
btw Buster is using mupdf 1.14 (whereas on Debian 9 I had issue with older muppdf)
There are no include, or lib folders.
Am I missing a step or a dependency?

Hello, just wanted to say how much I enjoy your FBPDF, FBFF, and NEATCC projects. Very well done!

I thought you might be interested to know that I ported both FBPDF and FBFF to Microwindows (a small-footprint graphical windowing system that runs on framebuffer, as well as other environments).I took your nicely-designed fb_ api in draw.c and made a few changes so they are identical across FBPDF and FBFF, and moved the keyboard input processing out of the main application into it as well so they are now portable across both environments.

Then, nxdraw.c was added to replace draw.c for the Nano-X environment, which handles some basic window creation, but uses the Nano-X capability of drawing directly into a memory-mapped window framebuffer such that the main application still uses the original fb_ api. All in all, pretty cool and very fast thanks to your neat design.

Now, the nxdraw.c and draw.c files are identical across the FBFF/FBPDF applications, and allow running on framebuffer or Nano-X with a quick change to the Makefile. I forked both projects and the code is there, in case you're interested. A couple bug fixes were made that causes core dumps with no audio playback, and width and height seperate zooms added.

Here's a screenshot of FBPDF running on OSX on Nano-X on SDL, no need to do anything, just wanted to say thanks!!

Please explain this error and how to work around it. Thank you.
(It is on a raspberry pi zero)

Git version. Any idea ?

mupdf.c: In function ‘doc_draw’:
mupdf.c:22:8: error: too many arguments to function ‘fz_new_pixmap_from_page_number’
pix = fz_new_pixmap_from_page_number(doc->ctx, doc->pdf, p - 1, &ctm, fz_device_rgb(doc->ctx), 0);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/mupdf/fitz.h:58:0,
from mupdf.c:3:
/usr/include/mupdf/fitz/util.h:22:12: note: declared here
fz_pixmap *fz_new_pixmap_from_page_number(fz_context *ctx, fz_document *doc, int number, const fz_matrix *ctm, fz_colorspace *cs);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mupdf.c:30:43: error: ‘fz_pixmap {aka struct fz_pixmap_s}’ has no member named ‘stride’; did you mean ‘storable’?
unsigned char *s = &pix->samples[y * pix->stride];
^~
Makefile:8 : la recette pour la cible « mupdf.o » a échouée
make: *** [mupdf.o] Erreur 1