Installation Trouble from cisTopic/R/RunModels.R about cistopic

[Toseph]

To get around the two "type=" errors, I changed the lines on 261 and 265 to "==" which allows cisTools to finish compile and installing on R from source, though it might have been incorrect to do so this way.

[root@rstudio-sanjana01 snapatac]# R CMD INSTALL cisTopic installing to library ‘/usr/lib64/R/library’ installing *source* package ‘cisTopic’ ... R Error in parse(outFile) : /root/snapatac/cisTopic/R/RunModels.R:261:33: unexpected '=' 260: 261: if (length(models) < 3 && type=

Error in parse(outFile) : /root/snapatac/cisTopic/R/RunModels.R:265:61: unexpected '=' 264: 265: if (is.null([email protected][['runWarpModels']]) && type=

Now when loading the library it loads but with warnings,

` > library(cisTopic)
There were 17 warnings (use warnings() to see them)

warnings()
Warning messages:
1: replacing previous import ‘GenomicRanges::shift’ by ‘data.table::shift’ when loading ‘cisTopic’
2: replacing previous import ‘data.table::last’ by ‘dplyr::last’ when loading ‘cisTopic’
3: replacing previous import ‘GenomicRanges::union’ by ‘dplyr::union’ when loading ‘cisTopic’
4: replacing previous import ‘GenomicRanges::intersect’ by ‘dplyr::intersect’ when loading ‘cisTopic’
5: replacing previous import ‘GenomicRanges::setdiff’ by ‘dplyr::setdiff’ when loading ‘cisTopic’
6: replacing previous import ‘data.table::first’ by ‘dplyr::first’ when loading ‘cisTopic’
7: replacing previous import ‘data.table::between’ by ‘dplyr::between’ when loading ‘cisTopic’
8: replacing previous import ‘dplyr::failwith’ by ‘plyr::failwith’ when loading ‘cisTopic’
9: replacing previous import ‘dplyr::id’ by ‘plyr::id’ when loading ‘cisTopic’
10: replacing previous import ‘dplyr::summarize’ by ‘plyr::summarize’ when loading ‘cisTopic’
11: replacing previous import ‘dplyr::count’ by ‘plyr::count’ when loading ‘cisTopic’
12: replacing previous import ‘dplyr::desc’ by ‘plyr::desc’ when loading ‘cisTopic’
13: replacing previous import ‘dplyr::mutate’ by ‘plyr::mutate’ when loading ‘cisTopic’
14: replacing previous import ‘dplyr::arrange’ by ‘plyr::arrange’ when loading ‘cisTopic’
15: replacing previous import ‘dplyr::rename’ by ‘plyr::rename’ when loading ‘cisTopic’
16: replacing previous import ‘dplyr::summarise’ by ‘plyr::summarise’ when loading ‘cisTopic’
17: replacing previous import ‘dplyr::collect’ by ‘text2vec::collect’ when loading ‘cisTopic’
`

[cbravo93]

Hi @Toseph !

Indeed, it was a typo I accidentally added in the last update yesterday, and your solution is correct. Now it should be solved.

Thanks a ton for reporting!

C