adospace / fluent-ui-xaml Goto Github PK

Steps to reproduce:
Add a ComboBox to a view and set property IsEditable to True

Expected result:
ComboBox in edit mode is rendered

Actual result:
XamlParseException is thrown - FabricComboBoxEditableTextBox resource cannot be found

Workaround:
Add the following style to merged dictionaries after FabricUI.TextBox.xaml and before FabricUI.ComboBox.xaml:

<Style x:Key="FabricComboBoxEditableTextBox" TargetType="{x:Type TextBox}" BasedOn="{StaticResource FabricTextBoxStyle}">
    <Setter Property="BorderThickness" Value="0,1,0,1"/>
    <Setter Property="BorderBrush" Value="{StaticResource Neutral.Gray130}" />
</Style>

Hi @adolfo-marinucci, thanks for this nice project which lets me easily modernize my older WPF appliction. I can give it the look&feel of my other Fleunt UI based projects.

Have you considered adding the fluentui:FabricExtra.ErrorMessage option (and required flag) to other input controls like ListBox, ComboBox etc?

If I have time I will give it a try, but current project presure leaves little or no space.

Thank you!

Hi. You should consider renaming this repo to FluentUI, and nuget with it, since the official naming changed few months back. Thanks

It should only require to define different colors: https://developer.microsoft.com/en-us/fluentui#/controls/web/link

Steps to reproduce:

1. Create a DataGrid with AutoGenerateColumns set to True
2. Bind it to a collection of objects for which not all columns have column definitions defined explicitly

Expected result:
DataGrid successfully generates missing columns

Actual result:

System.InvalidCastException
HResult=0x80004002
Message=Unable to cast object of type 'System.Windows.Controls.DataGridColumnCollection' to type 'System.Windows.Controls.DataGrid'.
Source=FluentUI
StackTrace:
at FluentUI.FabricHelper.<>c.<OnTextColumnStyleChanged>b__3_0(Object s, NotifyCollectionChangedEventArgs eventArgs)
at System.Collections.ObjectModel.ObservableCollection`1.OnCollectionChanged(NotifyCollectionChangedEventArgs e)
(...)

In FabricHelper.cs line 69 event sender is casted to DataGrid. When DataGrid adds a column automatically, sender is actually a DataGridColumnCollection

Referenced assembly 'FluentUI.NET, Version=1.0.51.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

As the brushes are hard coded into the FabricUI, and all references to the brushes as via StaticResource, one cannot override the brush colours. I was trying to do this to get a dark mode, but was unable to change any of the colours.

NuGet package v1.0.39 for .NET Core 3.1 contains changes from fluentui/desktop.

Release versions should follow master branch, as currently it leads to issues when trying to follow the example project.