Coder Social home page Coder Social logo

.github's People

Contributors

macdonst avatar purplecabbage avatar shazron avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

.github's Issues

Add default SECURITY.md

Security Policy

Reporting a Vulnerability

Use this section to tell people how to report a vulnerability.

Tell them where to go, how often they can expect to get an update on a
reported vulnerability, what to expect if the vulnerability is accepted or
declined, etc.

version-bump-publish.yml - does not work with Protected Branches with status checks

Expected Behaviour

Works with branches with status checks.

Actual Behaviour

Does not work with branches with status checks.

Possible Workarounds

  1. Enable force push, and update the workflow to force push (see Protected Branch settings screenshot below)
  2. There's also skip-checks: true in a commit message (perhaps we can do a git commit --amend after the npm version command?) https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-status-checks

Reproduce Scenario (including but not limited to)

Sample repo workflow error: https://github.com/adobe/generator-aio-app/runs/1763090447?check_suite_focus=true
Screenshot 2021-01-25 at 11 51 34 PM

Protected Branch Settings

Screen Shot 2021-01-25 at 11 52 06 PM

forks should not run publishing actions

Pushing to my own fork of and adobe repo modifies package.json, which in turn triggers the publish action. I of course do not have the npm credentials in my repo's secrets, so the publish fails, but it would be better if it did not run at all.

This will require some research into how repo-forks might be created without also forking the workflows, or having the workflows somehow aware that they are fork .. or check for existence of required secrets before running install/test actions which are resource hogs.

on-push-publish-to-npm.yml: 403 error

When I publish I get a 403 error:

npm ERR! code E403
130
npm ERR! 403 403 Forbidden - PUT https://registry.npmjs.org/@adobe%2fgenerator-aio-app - This package requires that publishers enable TFA and provide an OTP to publish. For more info, visit: https://go.npm.me/2fa-guide
131
npm ERR! 403 In most cases, you or one of your dependencies are requesting
132
npm ERR! 403 a package version that is forbidden by your security policy.

See:
https://github.com/adobe/generator-aio-app/runs/1763294230?check_suite_focus=true

I have ADOBE_BOT_NPM_TOKEN as an Org secret.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.