ada-audio / audio_wavefiles Goto Github PK

Ada Wavefile Library

License: MIT License

Ada 97.28% Shell 2.66% PowerShell 0.06%

audio wavefiles wavefile-reader wavefile-parser wavefile wavefile-features fixed-point floating-point pcm-data pcm-buffers

audio_wavefiles's People

Contributors

Stargazers

Watchers

Forkers

pjljvandelaar

audio_wavefiles's Issues

Simplify boolean expression

Why not replace

audio_wavefiles/src/audio-wavefiles.adb

Lines 50 to 52 in 8e1162c

    
           function No_Errors 
        
             (WF   : in out Wavefile) return Boolean 
        
           is (for all Error of WF.Errors => Error = False);

with

   function No_Errors (WF : in out Wavefile) return Boolean is
     (for all Error of WF.Errors => not Error);

Problem detected and solved by Rejuvenation-Ada crate

Prefer aspects over representation clauses

According to
https://ada.tips/use-ada-2012-aspects-to-specify-variable-locations.html
aspects should be prefered over representation clauses.

The file src/audio-riff-wav-formats.adb uses representation clauses twice.

Problem detected and solved by Rejuvenation-Ada crate

Use If Expressions to simplify code

Dear Audio_Wavefiles developers,

The source code isn't as readable as possible.
By using if expressions, both src/audio-wavefiles-write.adb and src/audio-wavefiles.adb can be simplified.

Problem detected and solved by Rejuvenation-Ada crate

Recommend Projects