abdelaz3r / sparkline_svg Goto Github PK

Hi, thanks for sharing this awesome library!

Is there a way to use only vertical padding?

When using smoothing (even the default 0.15), the line can be cropped at the top and bottom borders:

This can be fixed by setting padding, but then I also get horizontal padding, it would be great to have only padding at the top and bottom.

If the list of values has less than 2, we get this crash:

[error] GenServer #PID<0.1465.0> terminating
** (ArithmeticError) bad argument in arithmetic expression
    (sparkline_svg 0.3.0) lib/sparkline_svg/core.ex:132: SparklineSvg.Core.resize_x/3
    (sparkline_svg 0.3.0) lib/sparkline_svg/core.ex:62: anonymous fn/4 in SparklineSvg.Core.resize_datapoints/4
    (elixir 1.14.5) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
    (sparkline_svg 0.3.0) lib/sparkline_svg/core.ex:35: SparklineSvg.Core.compute/1
    (sparkline_svg 0.3.0) lib/sparkline_svg.ex:688: SparklineSvg.compute/1
    (sparkline_svg 0.3.0) lib/sparkline_svg.ex:605: SparklineSvg.to_svg/1
    (sparkline_svg 0.3.0) lib/sparkline_svg.ex:635: SparklineSvg.to_svg!/1

Maybe this could be handled by the library and return a better error?

If there are 0 values, I just don't show the sparkline, but I have a case where I can have 1 value:

In my stats I have a date selector that can display the last 7, 30 or 365 days, but the user can also choose to show a single day. In this case the library will crash, so a workaround might be showing 2 points when we have only 1, by repeating it:

However this feels a bit weird, it might be preferable to just show a single dot and no line?

Proposal of change:

SimpleCharts.new(datapoints, options2)
|> SimpleCharts.show_dots(options3)
|> SimpleCharts.show_line(options4)
|> SimpleCharts.show_area(options5)
|> SimpleCharts.add_dot(p1, options)
|> SimpleCharts.add_line(p2, options)
# or
|> SimpleCharts.add_annotation(:line, p1, options)
# or
|> SimpleCharts.add_line_annotation(p1, options)
|> SimpleCharts.to_svg()

1. Options are passed according to what we want (dots options are different than line options)
2. We add annotations for reporting incident (eg.)