zytedata / spidyquotes Goto Github PK

What do you think about moving the project to @scrapy organization, as it is used in Scrapy tutorial? We may also rename the project to quotes.toscrape.com, to make it more discoverable.

Create a home page containing links to the available endpoints. Something like this: https://demo.dexi.io

Hello,

On line 5 of templates/author.html

<h3 class="author-title">{{ author.name }}</h2>

... note that the H3 tag is closed with H2.

As a consequence, the following Scrapy code

response.css('h3.author-title::text').extract_first()

... will return "Albert Einstein\n " instead of "Albert Einstein"

This can be seen at the end of the Scrapinghub tutorial at

https://www.youtube.com/watch?v=JW_FxkSohkA

Of course, one could argue that the HTML parser used by Scrapy should fix this, as Chrome has no problem with it.

Kind regards,

Stephen Turner

The problem

On displays with a width less than 992 pixels the footer overlaps the "Top Ten tags" section:

Tested solutions

Increase margin-bottom

Increase the margin-bottom property on body to 120px.

Pros

• No major changes to the html or the css.

Cons

• Every time content is added to or removed from the footer margin-bottom needs updated.
• 120 pixels was gotten empirically.

Use flexbox

Add this to main.css:

body {
    display: flex;
    flex-direction: column;
    height: 100vh;
}

#content {
    flex: 1;
}

.footer {
    flex-shrink: 0;
    background-color: #f5f5f5;
}

then add the id="content" attribute to base.html:

<div id="content" class="container">
...
</div>
<footer class="footer">
...
</footer>

Pros

• No need to update when the footer changes.

Cons

• Not supported by older browsers: Can I use
• Requires a minor change to the html.
• Requires a major change to the css.

Feedback wanted

Any feedback on which solution to use or other possible solutions is appreciated.