zodiac1978 / wp-search-ignore-block-names Goto Github PK

Looks like an excellent solution. Does this filter backend searches as well? I find that searching for blocks can be quite useful there. Might be worth adding an is_admin()...
Source: Roy Tanck (@roytanck) on Twitter

To allow searching for blocks as well, we could add a toggle to enable/disable searching for block comments.

Your solution doesn't work when the search term is in both tags and content. ex: this is a paragraph the post with this content doesn't get captured when searching for "paragraph" because of the AND clause in your query

See: https://core.trac.wordpress.org/ticket/56294#comment:5

Unfortunately I did not find a simple way to achieve this with MySQL below 8.
Since MySQL 8 there is REPLACE_REGEXP which would solve this:
https://stackoverflow.com/questions/986826/how-to-do-a-regular-expression-replace-in-mysql

See: https://core.trac.wordpress.org/ticket/56294#comment:6

I will try to get this working at least with MySQL 8+ (and with the according MariaDB version). If this works, there needs to be some MySQL version checking built in.

A simplified Query for a standard search is this

SELECT SQL_CALC_FOUND_ROWS wp_posts.ID 
FROM wp_posts WHERE 1=1 
AND (((wp_posts.post_title LIKE '%wat%') 
OR (wp_posts.post_excerpt LIKE '%wat%') 
OR (wp_posts.post_content LIKE '%wat%')))

This plugin adds a new condition:

$where .= " AND REGEXP_REPLACE({$wpdb->posts}.post_content, '<.+?>', '') LIKE '%{$search_query}%'";

This breaks searching for title and excerpt.

We need to add the two OR statements again to fix this.

If there are problems with my approach that are not solvable, people maybe look for alternative solutions. We could provide them in the FAQ:

Possible alternatives:

• Elastic Search
• Relevanssi (https://wordpress.org/plugins/relevanssi/)

We could also ignore HTML markup like the plugin I was following to achieve the goal:
https://wordpress.org/plugins/wp-search-ignore-html-tags/

Reported upstream:
WordPress/gutenberg#49575
https://core.trac.wordpress.org/ticket/58080

Trying to do the same for shortcodes:
$where .= " AND REGEXP_REPLACE({$wpdb->posts}.post_content, '\[.+?\]', '') LIKE '%{$search_query}%'";

But although it works in my regex test ...
https://regex101.com/r/lbyiyL/1

... it does not work for the search.

Maybe @LinuxJedi can shed some light for me again :)