zlatkovsky / buildingofficeaddins Goto Github PK

Excel.run(obj, (ctx) => { ... })
Also add warning for not ending up in deadlock

InvalidArgument: https://stackoverflow.com/questions/44137567/merging-excel-cells-using-office-js/44168042?noredirect=1

Must return promise

Merge with property not loaded

Issue

Add a very quick overview of JS/TS, tailored particularly to the book.

On page 41, there is a link to download a JS file (DefinitelyTyped), but apparently the URL for the file changed.

Old link:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/office-js/index.d.ts

New link:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/office-js/index.d.ts

createArray(row, columns, fillIn?: boolean)

(Most is already written)

Armed with this newly-created function for creating Promsies
solve the rainbow scenario much more satisfactorily:

It should be Promises.

The correct would be:

function createRainbow() {
	var $rainbow = $("#rainbow");
	$rainbow.css("background", "red");
	setTimeout(function() {
		$rainbow.css("background", "orange");
		setTimeout(function() {
			$rainbow.css("background", "yellow");
			setTimeout(function() {
				$rainbow.css("background", "green");
				setTimeout(function() {
					$rainbow.css("background", "blue");
					setTimeout(function() {
						$rainbow.css("background", "indigo");
						setTimeout(function() {
							$rainbow.css("background", "violet");
						}, 2000);
					}, 2000);
				}, 2000);
			}, 2000);
		}, 2000);
	}, 2000);
}

Obs. 1: Sorry for changing ' to ", it is my linter.
Obs. 2: Maybe it is easier to change just var $rainbow = ... to var object = ..., as the very same error happens in pages 101 and 102, but a good jQuery script is to put $ as a prefix in jQuery variable names.

Issue

Add links from Chapter 5 to the GitHub samples, for population-analysis, gradebook, and stock-fetcher samples.

• Clearing personal data (image remove-personal-data)
• Auto-opening taskpane
• Passing in setting

[Please describe the issue here]

[Optional] Add a screenshot or a description of text before/after. (Page numbers and section numbers change all the time, and so aren't useful as reference points)

In environments that don't support tables: var tables = context.document.body.tables; the above tables var is defined. It just errors on load.

Was wondering if there would be any scope for this as large scale Add-ins need substantial frameworks.

https://groups.google.com/forum/#!searchin/leanpub/Zlatkovsky%7Csort:relevance/leanpub/82k-4FrbJEU/rVCEPk8tBQAJ

Typo:

1. ...it is always a best-practice to use “let“. In fact, if you’re only assigning
   a variable once and never re-assinging it, it is better to use an event
   stronger form of let: “const”....

should be: ..re-assigning it, it is better to use an even....

2. Very occasionally, you might have disagreement with the TypeScript
   compiler over a particular type. This happens primarily in Excel for 2Darray
   properties, such as values or formulas on an Excel.Range vobject.

should be: ...Excel.Range object.

2. Strings can be either be single-quoted or double-quoted, so long as the
   quote types match.

issue: extra "be"

In this section, you say that when a method or property gets called on a proxy, either an object path is created or an action, but that is not correct. All property access and method call create a new action, which operates on a object and may or may not create another object, which would then get assigned its object path.

(And differences between it and others, and between hosted in add-in vs native)

• history navigation

[Please describe the issue here]

[Optional] Add a screenshot or a description of text before/after. (Page numbers and section numbers change all the time, and so aren't useful as reference points)

var taxRate = retrieveTaxRate();

wrt the above, bcos previously u recommend always using let instead of var, should this example also use “let”?

You have a nice section “Loading on methods versus properties”. But the detailed example and solution give the impression that the problem only arises when the developer calls the same method twice, once before and once after the context.sync. I just discovered, the hard way, that the problem is more general than that. For example, the following code will get the error, even though the method settings.getItem method is only called after the context.sync. I suggest that you emphasize in the section that it doesn’t matter how the objects are loaded, when you use a method, you’re getting a brand new, unloaded, proxy object.

var settings = context.document.settings;
settings.add('startMonth', { month: 'March', year: 1998 });
settings.load('value');
return context.sync().then(function () {
	for (var i = 0; i < settings.items.length; i++) {

			// The next line works, so it’s natural for the developer to think that he’s loaded the individual settings.
			console.log(settings.items[i].value);
	}
	// But this line will fail for reasons given in your book.
   var month = settings.getItem('startMonth').value;
});

https://github.com/OfficeDev/generator-office/blob/master/readme.md

https://dev.office.com/docs/add-ins/get-started/get-javascript-intellisense-in-visual-studio

(See also http://stackoverflow.com/questions/42549170/how-to-port-existing-vb-net-office-add-ins-to-work-with-office-for-mac)

Already have one mostly-ready (pending chapters, resources.md)

Maybe a screenshot? Would help to explain/show the below:

Parameter type declarations. This is supremely useful, as it allows
you to split long procedures into multiple subroutines, and yet not
lose IntelliSense and compile-time error-checking. For example,
you can declare a function as
function updateValues(range: Excel.Range) { ... }
and be able to see all of the range properties/methods/etc. within the
body of the function, as opposed to seeing a dishearteningly-empty
IntelliSense list.

(And differences between it and others, and between hosted in add-in vs native)

history navigation

The REST query to yahoo does is not working out-of-the-box. Changed the URL as follows to get it to work. FYI.

    var data = 'q=' +
        encodeURIComponent(
            'select * from yahoo.finance.quote ' +
            'where symbol in (' + quotedCommaSeparatedNames + ')'
        ) +
        "&env=store%3A%2F%2Fdatatables.org" +
        "%2Falltableswithkeys&format=json";

[Please describe the issue here]

[Optional] Add a screenshot or a description of text before/after. (Page numbers and section numbers change all the time, and so aren't useful as reference points)

$('#run').click(() => {
    Excel.run(async (context) => {
        try {
            console.log('Your code goes here');
            await context.sync();
        }
        catch (error) {
            OfficeHelpers.Utilities.log(error);
        }
    });
});

Also tweak guidance to always do final sync.

Probably put as first section in Chapter 5, though may need to adjust the first section a bit.

Office 365 is the brand name Microsoft uses for a group of software and services subscriptions, which together provide productivity software and related services to subscribers. For consumers, the service allows the use of Microsoft Office apps on Windows and macOS, provides storage space on Microsoft's cloud storage service OneDrive, and grants 60 Skype minutes per month. For business users, Office 365 offers service plans providing e-mail and social networking services through hosted versions of Exchange Server, Skype for Business Server, SharePoint and Office Online, integration with Yammer, as well as access to the Microsoft Office software.

https://en.wikipedia.org/wiki/Office_365

https://dev.office.com/blogs/attach-debugger-from-the-task-pane