zhangt58 / beamline Goto Github PK

test_lattice.py fails with the File2jsonTest.
The JSON outputs/files differ in the following point:

1095d1094
<     "_epics": {},
1097,1098c1096,1097
<         "% 0 sto csr_on_off",
<         "% 0 sto lsc_on_off"

---
>         "% 0.0 sto csr_on_off",
>         "% 0.0 sto lsc_on_off"

Firstly the "_epics": {} is missing in the reference/test JSON and secondly the 0 is float and not string.

test_rot should be imported by 1.py, but it is not included in the repository.

There's no document for the preferred coding style, therefore I ask you if I might submit pull requests with changes (most often done by my editor) to make the modules PEP 8 conform and make pycodestyle and Flake8 warn one less.
Typical changes would be no space at the end of a line, spaces after commas, no unnecessary blank lines, etc.

beamline is designed to be an online modeling package for EPICS-control based accelerator, below is the subject that should be done or improved:

1. Documentation still need to be improved, especially the API section, i.e. better docstring is required;
2. Unit test, some testing scripts were inconsistent with the recent version of beamline, which should be fixed, and more testing scripts should be written to make the unit test completed;
3. MadParser class to handle lattice file according to MAD(8,X) convention, PR is created now;
4. The approach to handle EPICS interface variables in the lattice file should be improved, especially the Model class;
5. to be continued

As I wrote for pyrpn, I was wondering if there was anything that prevented this being expanded to allow use with python3?
(As before, I'm more than willing to do the work myself if you don't see any major stumbling blocks.)

The import of ParseParams, BeamMatch, FELSimulator and parseLattice fails, because matchutils can't be imported, because it is missing in the github repo.