zeruth / osjr Goto Github PK

Distortions are present in the gameframe size and component sizes
(slightly longer and taller than appears on windows)

This is because currently, the client cycles through every tile in Region (~10800 tiles). 50 times a second.

A simple fix is underway using baseX&Y to determine the objects Tiles position in a much more efficient way. Won't fix for now though, because my CPU doesn't really mind. Low end PC's see a tremendous slowdown though. and this will need to be fixed before first Release.

reproduce: Enable agility overlay while watching FPS counter.

This can be observed by using ::displayfps. Memory usage is absurd. Using Eclipse MAT shows that the majority of these objects are Fields.

While not bad for performance by any means (not really noticeable at all) - it's still bad practice, and a lot of these classes need to be re-evaluated with the way they handle new Objects. Especially Hooks.accessors.

The JVM will auto-free when you get too close to the maximum memory usage. In our case these references aren't held so the memory is freed back to a respectable range, but will continue this cycle repeatedly.

It is pretty easy to tell when this has happened. The client will get stuck at a black screen and never progress.

My preferred way of dealing with this would be to add a valid hooks check, and if it fails. load up the vanilla client instead of OSJR.

Good for first contribution.

I've made this VERY EASY with the way I designed SkillGlobe. Good for first contribution as this is a non-issue for me personally.