zenon-network / go-zenon Goto Github PK

I would like to propose activating discussions on the go-zenon repo. Does anyone have a strong opinion for or against that?

@georgezgeorgez @sumamu @MoonBaZZe

I think we should have a process to add / remove maintainers from repos. In particular the go-zenon repo. It appears I have the ability to add maintainers.

How do you guys feel about this process? If someone wants to be added as a maintainer, they can submit a request for access in a GH issue. For now, we could require 100% of maintainers to approve the addition of new maintainers by responding yes in the GH issue.

Thoughts?

Possibly confusing
Ran into it when I used the controller to migrate a normal full node from testnet to alphanet that was previously deployed using the controller

It later properly stated no pillar registered after syncing to the network

Commented as:
// Generates a deterministic seed based on the context
// formula depends on seed, weights and momentumHeight

Function in practice only depends on height

my understanding is that the seed is used to create a random permutation on pillars which have been sorted by delegation weight

theoretically as long as the number of pillars is the same and the rank of a pillar is the same, a pillar can determine at which heights it will be chosen in advance

changing this would be a consensus change

Link takes me here which is a 404

https://github.com/zenon-network/znn-wiki

https://tip.golang.org/doc/go1.18

Can't run latest version, even with a valid genesis.json I see this error:

no valid genesis file. Reason: 'invalid genesis config. Failed to pass tests'. Stopping ...

ISSUE:
Fork at Height: 6606104, Hash: 5328a743cc5cad623f7f727a7e757b58446923ec40166f54ab2890e53c949a1c

Bad state: The client closed with pending request "embedded.pillar.getAll".

BACKGROUND:
At block height 6606104 it appears we suffered a fork. Nodes are unable to sync past this block height. We believe the fork was caused by sort.Slice in the staking embedded contract. We think this is the same issue we encountered with the AZ Embedded Contract: the sort function is not returning the same values to all nodes.

Possible location of the bug.

Can we investigate all instances of sort.Slice in the code and update them?

Issue: embedded.sentinel.getDepositedQsr returns null when the address has 50,000 qsr deposited for a registered sentinel.

"This API call will return the amount of QSR the address has deposited in order to create a Sentinel."

z1qzgdv2ll8hjxfja0pdcdyk6gu9twxs4zutj39f is a registered Sentinel. Yet when I call this endpoint, it returns null

Steps to Reproduce:

request

curl -X POST https://my.hc1node.com:35997 \                                                                                                                  ok  
  -H 'Content-Type: application/json' \
  -d '{"jsonrpc": "2.0", "id": 14, "method": "embedded.sentinel.getDepositedQsr", "params": ["z1qzgdv2ll8hjxfja0pdcdyk6gu9twxs4zutj39f"]}'

response

{"jsonrpc":"2.0","id":14,"result":"0"}

I've confirmed the same response on the zenonhub.io API Playground