zendesk / redux-entities Goto Github PK

Hi Alex !
I'm coming from your message on Slack.
Awesome work !

I've looked through both your packages and I have minor advice :

• I think the main entry in your package.json isn't set correctly, people might not be able to use it as-is out of the box.
• following the previous point, I think you should commit your webpack's built package in a dist folder for example, and set this as the main entry in the package.json. So people will have a working import stuff from 'your-package';
• finally, maybe some tests 😜, it will be reassuring for everyone using your lib.

Anyway, really good and useful libraries.
Cheers!

Quick feature idea: Add ability to denormalize in selectors like getById

https://github.com/paularmstrong/normalizr/blob/master/docs/api.md#denormalizeinput-schema-entities

Potential ways it could be set up:
Option 1: Add a denormalize prefix that wraps all of the selectors
todoSelectors.denormalize(todoSchema).getById(state, 1)

Option 2: Pass schema in as third argument to getById
todoSelectors.getById(state, 1, todoSchema)
Although this is the cleanest in my opinion, this limits options in the future.
E.g. passing in a default as the third argument

Option 3: Pass schema in as third argument to createEntitySelectors. Then all selectors are denormalized by default
const todoSelectors = createEntitySelectors('todo', getEntities, todoSchema)