x8xx (Network Management) messages are treated as invalid about iso_8583

[zemuldo]

Hi Tim. Sorry for my late response. I will review the fixes and test tomorrow and also see the new version uploaded. Thanks.

…

On Nov 24, 2017 19:17, "Tim Gabets" ***@***.***> wrote: let data = { 0: '0100' }; let isopack = new iso8583(data); isopack.validateMessage(); > true let data = { 0: '0800' }; let isopack = new iso8583(data); isopack.validateMessage(); > false x8xx messages are the part of ISO8583 <https://en.wikipedia.org/wiki/ISO_8583#Message_class> as well, and must pass validateMessage() check. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATB9ZUBmcRR_kpvEzvwo33HrIP5SZ3NGks5s5uvPgaJpZM4QqAMj> .

[zemuldo]

Hi Tim
The test for 0800 valid message goes through.

test('getMti() should return proper MTI for 1820', t => {
  let data = {
     0: '0800',
     70: '001'
  };
  let isopack = new Main(data);
  t.is(isopack.validateMessage(), true);
  t.is(isopack.getMti(), '0800');
});
test('getMti() should return proper MTI for 1820', t => {
    let data = {
        0: '1899',
        70: '001'
    };
    let isopack = new Main(data);
    t.is(isopack.validateMessage(), false);
});

All passed

[zemuldo]

Hey Tim, I hope you have validated before closing this issue.

[timgabets]

Hi, I've seen the covered test case, that's enough for now ;)