Secondary Bitmap - exclusion about iso_8583

[zemuldo]

Thank you for the gesture of appreciation. It means a lot for me. This is a generic library for ISO 8583 and my initial usecase was to connect to a Postilion Post-Bridge interface.

I see your point, I will have a look at the line you mentioned and see what we can do. I think this can be made configurable so that when these fields are absent, you can choose to always not include the secondary bitmap.

[csvdf]

Hi zemuldo,
First of all, thanks for producing a very useful library, been trying it for a proof of concept and its been useful.
I am also running into this issue above, where the optional Secondary bitmap is always being added.
Have you looked into this issue any further?
Thanks

[zemuldo]

Hi, I have a branch that I can push for you to test. Does make the library configurable to exclude the secondary bitmap seem like a solution that can work for you? In this case when initialising there would be a way to pass that in the init config object. Let me know if this will work for you.

[csvdf]

Hi, I think being able to pass in configuration should work.
Let me try it out when you have a branch available, Thanks

[zemuldo]

I have tried something that looks like this

let isopack = new Main(data);
isopack.optionalSecondaryBitmap = true;

After the second line, packaging a message that results without any of field 64-128 will have no secondary bitmap.
Also calling unpack on a buffer message that has 0 on the first value of primary bitmap will also be treated without secondary bitmap.

One part of this unpacking part existed before and this seems like a bug. The flag is for backward compatibility on someone using the library with the bug. Let me know what you think.

[zemuldo]

@csvdf check this change and see if it solves the problem. The branch is on #113

[zemuldo]

Merged

[csvdf]

Hi, just checking if this was added to a release build yet?