zefman / flam3 Goto Github PK

What steps will reproduce the problem?  =============
1. Pick  a background color like orange: "255 128 64"

What is the expected output? What do you see instead? ================
You should see that color as the background color. Instead I get white as the 
rendered background color.

If I set white as the background color, I see white, but much of the fractal is 
overlaid with white. (You can see the non-background areas of the fractal by 
specifying a transparent render.)

If I set black as the background color, the render shows the correct result.

What version of the product are you using? On what operating system? ===========
flam3-render version 3.0.0
Mac OS X

Please provide any additional information below. =================
Analysis: the following lines of code in rect.c lines 1072 - 1074 cause the 
error:
Change:
      background[0] /= vib_gam_n/256.0;
      background[1] /= vib_gam_n/256.0;
      background[2] /= vib_gam_n/256.0;
To:
      background[0] /= vib_gam_n;
      background[1] /= vib_gam_n;
      background[2] /= vib_gam_n;

The original code caused background color values 256 X larger than they should 
have been. Those values were then clipped to 255. (that is why an orange 
background became white and also explains why
when the background color was set to white, the white background overlaid a lot 
of the fractal
[alpha blending a very BIG number with the fractal colors caused the colors to 
overflow and be clipped as white].
It also explains why a background color of black worked properly.  0 X 256 => 0

I tested with my own copy of the code and this change fixed the bug.

What steps will reproduce the problem?
1. ./configure
2. make


What is the expected output? What do you see instead?

make  all-am
make[1]: Entering directory `/home/mkaushik/Download/flam3-read-only/src'
/bin/sh ./libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.   
-I/usr/include/libxml2  -g -O3 -std=gnu99 -ffast-math 
-DPACKAGE_DATA_DIR=\"/usr/local/share/flam3\" -D'SVN_REV="15"'  -c -o flam3.lo 
flam3.c
./libtool: line 827: X--tag=CC: command not found
./libtool: line 860: libtool: ignoring unknown tag : command not found
./libtool: line 827: X--mode=compile: command not found
./libtool: line 994: *** Warning: inferring the mode of operation is 
deprecated.: command not found
./libtool: line 995: *** Future versions of Libtool will require --mode=MODE be 
specified.: command not found
./libtool: line 1138: Xgcc: command not found
./libtool: line 1138: X-DHAVE_CONFIG_H: command not found
./libtool: line 1138: X-I.: command not found
./libtool: line 1138: X-I/usr/include/libxml2: No such file or directory
./libtool: line 1138: X-g: command not found
./libtool: line 1138: X-O3: command not found
./libtool: line 1138: X-std=gnu99: command not found
./libtool: line 1138: X-ffast-math: command not found
./libtool: line 1138: X-DPACKAGE_DATA_DIR="/usr/local/share/flam3": No such 
file or directory
./libtool: line 1138: X-DSVN_REV="15": command not found
./libtool: line 1138: X-c: command not found
./libtool: line 1191: Xflam3.lo: command not found
./libtool: line 1196: libtool: compile: cannot determine name of library object 
from `': command not found
make[1]: *** [flam3.lo] Error 1
make[1]: Leaving directory `/home/mkaushik/Download/flam3-read-only/src'
make: *** [all] Error 2

What version of the product are you using? On what operating system?

Checked out latest source using svn checkout

Please provide any additional information below.

In src/libtool, replacing ECHO="echo" by echo="echo" fixed the error above and 
I was able to build successfully.

What steps will reproduce the problem?
1. Install libpng 1.4.2
2. Install flam3
3. Try to compile anything against flam3 that's using it's pkg-config file

What is the expected output? 

Succesful ./configure; make

What do you see instead?

Fails to detect perfectly working libpng installation.

What version of the product are you using? On what operating system?

Linux. Gentoo. Could as well be Arch Linux, they migrated to libpng 1.4
also. Others will follow. It's only matter of time.

Please provide any additional information below.

Replace "libpng12" with "libpng" in flam3.pc.in because libpng-devel
includes libpng.pc, so it will work for both libpng 1.2 and libpng 1.4

http://code.google.com/p/flam3/source/browse/trunk/src/flam3.pc.in

sed -i -e 's:libpng12:libpng:' flam3.pc.in

What steps will reproduce the problem?
1. compilation of libflam3 (3.0.1) under cygwin with libpng 1.5

What is the expected output? What do you see instead?
compilation should succeed, but I got compile errors when compiling file png.c

png.c:145:28: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:164:20: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:166:14: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:170:20: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:171:21: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:173:44: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:175:22: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:176:19: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:185:14: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:189:28: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:195:28: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:197:30: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:199:23: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen
png.c:220:28: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen

(this is a german error massage, in English it is:
  error: dereferencing incomplete pointer type)
This concerns the pointer 'info_ptr'. The struct is now made opaque in the 
libpng API
and its components have to be accessed via accessor functions.

What version of the product are you using? On what operating system?
3.0.1 under cygwin under Windows XP.

Please provide any additional information below.
Patch for file png.c is attached. Test renders have succeeded.

Thanks for your work!

The flam3 website (http://flam3.com/index.cgi?&menu=code) says that a 
regression testing script exists. It exists in the old source repository under 
src/test, it doesn't seem to exist in the new 3.0 repository.

What steps will reproduce the problem?
1. Checked out revision 164 with a new Ubuntu 14.04 installation
2. normal configure, make
3. testing with ./flame-render < test.flam3

What is the expected output? What do you see instead?

./flam3-render < test.flam3
flame = 1/2
chaos: 100.0%  took: 0 seconds
filtering...Segmentation fault (core dumped)

What version of the product are you using? On what operating system?
revision 164 with a new Ubuntu 14.04 installation

Here a patch to add Haiku operating system (http://www.haiku-os.org) support.

This will fix number of "error: dereferencing pointer to incomplete type" 
errors caused by new API requirements in libpng 1.5

The patch should work with 1.2 and 1.4 too as is

So the minimum libpng version should be raised to 1.2 in pkg-config file when 
applying this

Thanks, Samuli

What steps will reproduce the problem?
1../configure
2.make
3.make install

What is the expected output? What do you see instead?
make fails and outputs is as follows:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/opt/local/include/libxml2 -g -O3 
-std=gnu99 -ffast-math -DPACKAGE_DATA_DIR=\"/usr/local/share/flam3\" 
-DSVN_REV=\"exported\" -c png.c -o png.o
png.c: In function ‘read_png’:
png.c:145: error: dereferencing pointer to incomplete type
png.c:164: error: dereferencing pointer to incomplete type
png.c:166: error: dereferencing pointer to incomplete type
png.c:170: error: dereferencing pointer to incomplete type
png.c:171: error: dereferencing pointer to incomplete type
png.c:173: error: dereferencing pointer to incomplete type
png.c:175: error: dereferencing pointer to incomplete type
png.c:176: error: dereferencing pointer to incomplete type
png.c:185: error: dereferencing pointer to incomplete type
png.c:189: error: dereferencing pointer to incomplete type
png.c:195: error: dereferencing pointer to incomplete type
png.c:197: error: dereferencing pointer to incomplete type
png.c:199: error: dereferencing pointer to incomplete type
png.c:220: error: dereferencing pointer to incomplete type
make[1]: *** [png.lo] Error 1
make: *** [all] Error 2


What version of the product are you using? On what operating system?
v3 on OSX 10.7.5

Please provide any additional information below.
I cannot get oxidizer to run satisfactorily, so I am trying to install qosmic. 
I have installed all the listed dependencies listed in the read me file, I have 
even attempted alternate installation methods listed. Only more issues. 
Please help .

from  David Burnett at http://community.electricsheep.org/node/804

... in flam3-animate you've left the call to write_png hard coded for an 8 bit 
png while the data is 16 bit so its just a matter of changing line 285 in 
flam3-animate.c

- write_png(fp, image, cps[0].width, cps[0].height, &fpc, 1); 
+ write_png(fp, image, cps[0].width, cps[0].height, &fpc, f.bytes_per_channel);

Edit: This in in both 2.7 and 3.0 versions of flam3

flam3-genome should take a --version option that causes it to just print the 
version string to stdout without any quotes or other verbiage.  this is to be 
machine readable by the config scripts to confirm we have the right version.