Coder Social home page Coder Social logo

Crash with from_data() about gdinv HOT 3 CLOSED

zcaliptium avatar zcaliptium commented on June 11, 2024
Crash with from_data()

from gdinv.

Comments (3)

kimabjorkede avatar kimabjorkede commented on June 11, 2024

I also remember having to remove a type-specifier from a line because it crashed the game on launch. I can't remember what line it was. I think it was a variable that was defined as an array, but the script forced a dictionary upon it.

from gdinv.

zcaliptium avatar zcaliptium commented on June 11, 2024

Why new_stack.stackSize = stacks_data[i].stackSize was added?

The GDInv_ItemStack.from_data should do that. Isn't it?

gdinv/GDInv_ItemStack.gd

Lines 25 to 37 in 8a08eea

func from_data(json_data: Dictionary):
var item_id = json_data.get("item", "null");
var size = json_data.get("stackSize", 0.0);
var caps = json_data.get("capabilities", {})
if (typeof(item_id) == TYPE_STRING and item_id != "null"):
item = GDInv_ItemDB.get_item_by_id(item_id);
if (typeof(caps) == TYPE_DICTIONARY):
capabilities = caps;
if (typeof(size) == TYPE_REAL):
stackSize = int(size);

from gdinv.

zcaliptium avatar zcaliptium commented on June 11, 2024

Okay... That could be TYPE_INT sometimes. In case if you do to_data and then from_data without converting it into JSON.

Created new issue ticket for that. #16

from gdinv.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.