yzhang / ar_mailer_rails3 Goto Github PK

migration should be: t.integer :last_send_attempt, default: 0, null: false

Failure condition:

1. Create a new mail
2. run ar_sendmail_rails3 --mailq

And there will be errors because there is a comparison on line 134 with a nil value

Should probably do something with Rails.env. It looks like during testing, this gem actually tries to send mail but fails with a connection failure unless it's configured.

Maybe also look into ActionMailer::Base.deliveries and see how that's used during testing?

http://edgeguides.rubyonrails.org/action_mailer_basics.html#mailer-testing

I just installed this and did a deliver on a mailer object. This is the error I got with the fresh install. Ideas?

[~/km/sio/trunk]$ ar_sendmail_rails3 --mailq
-Queue ID- --Size-- ----Arrival Time---- -Sender/Recipient-------
1 4564 Tue Oct 05 20:45:53 [email protected]
Unhandled exception undefined method >' for nil:NilClass(NoMethodError): /Users/daniel/.rvm/gems/ruby-1.9.2-p0/gems/activesupport-3.0.0/lib/active_support/whiny_nil.rb:48:inmethod_mis
sing'
/Users/daniel/.rvm/gems/ruby-1.9.2-p0/gems/ar_mailer_rails3-2.1.10/lib/ar_mailer_rails3/ar_sendmail.rb:134:in b lock in mailq' /Users/daniel/.rvm/gems/ruby-1.9.2-p0/gems/ar_mailer_rails3-2.1.10/lib/ar_mailer_rails3/ar_sendmail.rb:118:ine
ach'
/Users/daniel/.rvm/gems/ruby-1.9.2-p0/gems/ar_mailer_rails3-2.1.10/lib/ar_mailer_rails3/ar_sendmail.rb:118:in m ailq' /Users/daniel/.rvm/gems/ruby-1.9.2-p0/gems/ar_mailer_rails3-2.1.10/lib/ar_mailer_rails3/ar_sendmail.rb:279:inr
un'
/Users/daniel/.rvm/gems/ruby-1.9.2-p0/gems/ar_mailer_rails3-2.1.10/bin/ar_sendmail_rails3:5:in <top (required)> ' /Users/daniel/.rvm/gems/ruby-1.9.2-p0/bin/ar_sendmail_rails3:19:inload'
/Users/daniel/.rvm/gems/ruby-1.9.2-p0/bin/ar_sendmail_rails3:19:in `

I guys (sorry for my english i'm french ...),
i've started to use your awesome gem with a newsletter project but when i pass ma project on the production server i encountered a problem to send mail with my local smtp.
Line 374 to 382 in ar_sendmail.rb, when i comment this line, it correct my problem.
In futur version, it possible to change this part or upgrade with a log message to show the problem in log ?