ystero-dev / ellora Goto Github PK

It is observed that cargo test fails on MacOs. Right now this is disabled in CI. But we would like to root cause this and fix that issue, so that this does not have to be disabled on MacOs builds

With the latest commit, it is possible to use this crate on MacOS as well, it is a good idea to add the CI runners for MacOS as well.

Right now if one looks at the integration tests inside say tests/connected_socket/mod.rs, there is a duplication of code for creating client socket and accepting on listener socket. Similar opportunities exist in other integration tests. As a first step, it's a good idea to identify such refactoring improvements and a second step would be to fix those.