yosyshq / setup-oss-cad-suite Goto Github PK

I really love your OSS CAD tool builds and the Chisel community has come to rely on them. Unfortunately the github action to set them up has been very flaky, especially on MacOS, but also on Linux lately. We ended up replacing it with our own action: chipsalliance/chisel#2901

Just wanted to let you know in case this is useful for improving your Github action. Thank you so much for providing the binaries!

Hi,

it would be very nice to integrate iStyle verilog code formatter!
https://github.com/thomasrussellmurphy/istyle-verilog-formatter/

Best,

Spline

The should be done on a best-effort basis (as in not fail the action/workflow due to not being able to ensure symlink is setup, it should report it was unable to create the symlink in a message back to the user to help with diagnostics, but not really alarm the user too much over, as many thing will still work).

# || true to counter any 'set -e' failure mode
[ -e /yosyshq ] || sudo ln -s $RUNNER_TEMP/oss-cad-suite /yosyshq || true

if [ ! -e /yosyshq ]; then
  echo "WARNING: Unable to ensure setup of symlink /yosyshq, some things may not work as well as expected.  ln -s  $RUNNER_TEMP/oss-cad-suite /yosyshq" 1>&2
fi

Note the use of 'sudo' to write into the / directory from a GHA workflow.

Feel free to make a better more informative message, explaining what was trying to be done,

Why is this needed?

Some things inside oss-cad-suite have a compiled-in paths (such as the Python interpreters) that work as-is if their expected installation path is found. All the user needs to do is source $OSS_CAD_HOME/environment and then use Python binary from oss-cad-suite.

Another solution is for the user to export PYTHONHOME=$RUNNER_TEMP/oss-cad-suite which has the same effect but uses the envvar to override the compiled in location /yosyshq/lib/python3.8. However this must be done after source $OSS_CAD_HOME/environment because the script oss-cad-suite provide appears to blank out the existing value.

It would be great if this action also worked on mac-os. Since most users of Chisel are using mac to do their development I try to have at least some MacOS tests in the chiseltest CI: ucb-bar/chiseltest#441

Hi,

this would also a good addon in your suite!
DESCRIPTION
Vrename will allow a signal to be changed across all levels of the design hierarchy, or to create a cross reference of signal names. (It actually includes module names, macros, and other definitions, so those can be changed too.)

https://metacpan.org/dist/Verilog-Perl/view/vrename