yorkie-team / yorkie-ios-sdk Goto Github PK

View Code? Open in Web Editor NEW

16.0 6.0 4.0 2.19 MB

Yorkie iOS SDK

Home Page: https://yorkie.dev/docs/ios-sdk

License: Apache License 2.0

Swift 99.99% Shell 0.01%

crdt ios swift realtime-collaboration yorkie hacktoberfest

yorkie-ios-sdk's People

Contributors

Stargazers

Watchers

Forkers

hyeongsik-won wi-seong-cheol auaicn hs-won

yorkie-ios-sdk's Issues

Why:

Support for OperationInfo inference on Document.subscribe

Description:
yorkie-team/yorkie-js-sdk#535
Why:

Add actor to ChangeInfo / update api-reference

yorkie-team/yorkie-js-sdk#508

Implement yorkie.Tree for text editors using tree model

Description:
yorkie-team/yorkie-js-sdk#507
Why:

Sync mode(push pull, pushonly)

yorkie-team/yorkie-js-sdk#495
yorkie-team/yorkie-js-sdk#497

Memory leak in iOS TextEditorApp Sample

What happened:

Run TextEditorApp Sample from the project.
Tap on Text Editor button to open an empty textView.
Yorkie Client Activatation Fails
Tap on the Yorkie Sample back button to pop TextEditorViewController from the current NavigationController
TextEditorViewController still remains in memory.

What you expected to happen:

TextEditorViewController should be removed from the memory

How to reproduce it (as minimally and precisely as possible):

As described above

Anything else we need to know?:

Inside TextViewModel.swift's func cleanup(), since detaching a client throws YorkieError.clientNotActive error, I had to handle the error with do...catch instead of force unwrapping with try!

    func cleanup() async {
        do {
            try await self.client.detach(self.document)
            try await self.client.deactivate()
        } catch {
            // handle error
//            print("error = \(error.localizedDescription)")
        }
    }

I tried weak capturing of self in every closure that resides in TextEditoApp project with no luck.

Environment:

Operating system: iOS 16.4
Yorkie version (use yorkie version): 0.3.6
Yorkie iOS SDK version: 0.3.6

Allow specifying a topic when subscribing to a document

yorkie-team/yorkie-js-sdk#487

Fix when searching for presence of non-existent peer

yorkie-team/yorkie-js-sdk#493