yoavweiss / blink Goto Github PK

AXURL is null, instead of the src

In a contenteditable element, when the caret immediately precedes a <picture><source /></picture>, hitting delete or calling document.execCommand('Delete') removes the <source>.

Given:

<picture>
  <source src="image1.png" />
  <source src="image2.png" />
  <img src="image3.png" />
</picture>

...all three images are downloaded

e.g.

var span = document.getElementsByTagName('span')[0];
span.innerHTML = "<picture id='2' name='newImage'></picture>";
return !!document.newImage

...returns false, should be true

<picture> does not load a <source> that is set dynamically with JS, using for e.g. source.src = 'file.png'.

Just having a look through https://github.com/yoavweiss/Blink/blob/master/Source/core/html/parser/HTMLSrcsetParserTest.cpp and it doesn’t look like there’s a test for an omitted 1xflag:

1x.gif, 2x.gif 2x

<picture> can't be dragged, which causes problems for drag-and-drop (e.g. dragging a picture into a contenteditable region).

Doing <picture src="" /> (i.e. with a self-closing tag) fails. The tag is never closed, and any subsequent content is treated as a child of <picture>.

should be alternate, but is empty

I've got the threadsafe calc() impl working , and added a bunch of tests, but many more are needed.