yoavain / hebrewsubtitledownloader

Automatically exported from code.google.com/p/hebrewsubtitledownloader

👋 Hey there I'm Yoav - @yoavain

I am a full stack developer from Israel, working at SundaySky as a Senior Software Engineer.

My Expertise

Languages:

Platforms / Frameworks:

Tools:

IDE:

CI/CD:

DB:

Opensource contributions

• Creator of:
  create-windowless-app
  
  fix-lockfile-integrity
  

• Contributor for:
  node-notifier
  webpack-build-notifier
  npq
  lockfile-lint
  lockfix
  IntelliJ IDE Extra Icons plugin

Stats

Get in touch

hebrewsubtitledownloader's Issues

SubsCenter.org site changed (thanks ofird)

Subtitles can be found, but cannot be downloaded.
Site added "key" to download url.

Example:
Old link:
http://www.subscenter.org/he/subtitle/download/he/248194/?v=Source.Code.REPACK.7
20p.Bluray.x264-MHD
New link:
http://www.subscenter.org/he/subtitle/download/he/248194/?v=Source.Code.REPACK.7
20p.Bluray.x264-MHD&key=727050269ef71311d900eea0f0aa204a

Original issue reported on code.google.com by yoavain on 26 Nov 2011 at 4:31

Filter only subtitle files on SaveSubtitle()

Example: 

last House MD contained:
.idx
.sub
2 other files

Should not return the non subtitle

Original issue reported on code.google.com by yoavain on 23 May 2011 at 3:44

Add www.torec.net

Add support for http://www.torec.net/

Original issue reported on code.google.com by yoavain on 11 May 2011 at 2:42

"www.subscenter.org" became "www.bsubs.com"

Change code accordingly...

Original issue reported on code.google.com by yoavain on 16 May 2011 at 5:13

subtitle.co.il needs user password

Must have cookie in order to see subtitles.

Original issue reported on code.google.com by yoavain on 22 Aug 2013 at 11:50

Filtering languages in query

Implement filtering by languages in query

Original issue reported on code.google.com by yoavain on 11 May 2011 at 5:56

Use subwcrev in PreBuildEvent

Use subwcrev in PreBuildEvent for replacing version

Original issue reported on code.google.com by yoavain on 11 May 2011 at 1:43

SubSenter now work with user and password

User is unbale to downloader via media portal.

Can you update the plug?

Thanks

Original issue reported on code.google.com by [email protected] on 25 Jan 2014 at 11:28

Stable extension

Stable extension

Original issue reported on code.google.com by yoavain on 26 Nov 2011 at 10:24

Sratim.co.il - TV Series not working

(Self explanatory)

Original issue reported on code.google.com by yoavain on 7 Apr 2012 at 9:14

Check Sratim.co.il limits

Check cookies to see if registered users can avoid limitations

Original issue reported on code.google.com by yoavain on 15 Nov 2011 at 7:56

Both providers stopped working. not getting any result in subcentral search. (other providers do work, subtitles exist on site)

What steps will reproduce the problem?
1.searching for subs in one of the providers

What is the expected output? What do you see instead?
expected: downloading. instead: "subtitle not found". while the sites have the 
subtitles.

What version of the product are you using? On what operating system?
the current version. April 2012.

Please provide any additional information below.

Thanks. Much appreciated. 

Original issue reported on code.google.com by [email protected] on 30 Dec 2012 at 7:53

Some movies takes too long to process in Sratim.co.il

What steps will reproduce the problem?
The movie "Lucky" returns 21 possible matches, and the current algorithm 
download every single page, and goes create a list from all pages.

What is the expected output? What do you see instead?
Should try to get an exact match from the initial query, based on title/year.

Original issue reported on code.google.com by yoavain on 16 Nov 2011 at 6:42

Sratim.co.il movies parsing is broken

What steps will reproduce the problem?
Try downloading movie subs from Sratim.co.il (check that it exists on site)

Original issue reported on code.google.com by yoavain on 29 Dec 2012 at 3:52

Add sratim.co.il

Add support for http://sratim.co.il/

Original issue reported on code.google.com by yoavain on 11 May 2011 at 6:03

www.sratim.co.il --> http://www.subtitle.co.il

Site has changed

Original issue reported on code.google.com by yoavain on 4 Apr 2012 at 7:42

Error handling

Error handling - According to API standards and other implementations

Original issue reported on code.google.com by yoavain on 11 May 2011 at 5:55

Use English site instead of Hebrew one

Use http://www.subscenter.org/en/

Reasons:
1. Will be easier to parse (no RTL)
2. Will have English series name for validation

Original issue reported on code.google.com by yoavain on 15 May 2011 at 10:24

Sratim.co.il - When zip contains idx+sub download only sub

Sratim.co.il - When zip contains idx+sub download only sub

Original issue reported on code.google.com by yoavain on 3 Dec 2011 at 10:19

Add configurable series name translation for better matches

Add configurable series name translation for better matches.

For example:
"house" --> "house md"
"castle 2009" --> "castle"
"the office (us)" --> "the office"
"the office (uk") --> "the office uk"

etc.

Original issue reported on code.google.com by yoavain on 17 May 2011 at 5:57

Some code improvement suggestions

Hi and thanks for your contribution for SubtitleDownloader.

I have some suggestions for your code:

1. class name SubsCenterOrgDownoader should probably be SubsCenterOrgDownloader 
:)

2. Code like this may hide some real errors. You should let the exception raise 
if something goes wrong, otherwise it is impossible to know why the download 
fails.
171       catch (Exception) 
172       { 
173         return new List<FileInfo>();    
174       }

3. If the site only supports English and Hebrew, make checks what languages the 
search query has and just return empty results immediately if none of the 
supported languages are included in search query

- seco

Original issue reported on code.google.com by [email protected] on 19 May 2011 at 10:54