yklcs / linalg Goto Github PK

Transposing a matrix is well defined even if a matrix is non-square. However, this module keeps failing to transpose a non-square matrix. The code was
M = linalg.Matrix([[1],[2],[3]])
M.T()
and this led to an IndexError.

Traceback (most recent call last):
File "<pyshell#10>", line 1, in
M.T()
File "C:\Users\SYJ\AppData\Local\Programs\Python\Python36\lib\site-packages\linalg\types.py", line 63, in transpose
return linalg.unary.transpose(self)
File "C:\Users\SYJ\AppData\Local\Programs\Python\Python36\lib\site-packages\linalg\unary.py", line 71, in transpose
return Matrix([[mat[a][b] for a in range(y)] for b in range(x)])
File "C:\Users\SYJ\AppData\Local\Programs\Python\Python36\lib\site-packages\linalg\unary.py", line 71, in
return Matrix([[mat[a][b] for a in range(y)] for b in range(x)])
File "C:\Users\SYJ\AppData\Local\Programs\Python\Python36\lib\site-packages\linalg\unary.py", line 71, in
return Matrix([[mat[a][b] for a in range(y)] for b in range(x)])
IndexError: list index out of range

I tried to transpose a different matrix,
M = linalg.Matrix([[1,2,3],[4,5,6]])
M.T()
and same error raised.

Traceback (most recent call last):
File "<pyshell#29>", line 1, in
M.T()
File "C:\Users\SYJ\AppData\Local\Programs\Python\Python36\lib\site-packages\linalg\types.py", line 63, in transpose
return linalg.unary.transpose(self)
File "C:\Users\SYJ\AppData\Local\Programs\Python\Python36\lib\site-packages\linalg\unary.py", line 71, in transpose
return Matrix([[mat[a][b] for a in range(y)] for b in range(x)])
File "C:\Users\SYJ\AppData\Local\Programs\Python\Python36\lib\site-packages\linalg\unary.py", line 71, in
return Matrix([[mat[a][b] for a in range(y)] for b in range(x)])
File "C:\Users\SYJ\AppData\Local\Programs\Python\Python36\lib\site-packages\linalg\unary.py", line 71, in
return Matrix([[mat[a][b] for a in range(y)] for b in range(x)])
File "C:\Users\SYJ\AppData\Local\Programs\Python\Python36\lib\site-packages\linalg\types.py", line 121, in getitem
return self.matrix[i]
IndexError: list index out of range

Maybe the location of variables 'x' and 'y' had been changed in this part?

return Matrix([[mat[a][b] for a in range(y)] for b in range(x)])

This should be...

return Matrix([[mat[a][b] for a in range(x)] for b in range(y)])

like this?