yipeng945 / reactjs-practice Goto Github PK

One suggestion:

For the css layout part, try use flexbox or CSS grid instead of float, percentage of width, etc. It is more powerful and most of the companies have already moved to flexbox and CSS grid from traditional layout methods.

Timer issue

So suppose that the time when I press the start button is 0 sec.
Then at 1.8 sec the number showing is 1, I press reset button.
Then I should see the number jump to 0 from 1 (which is good in your code), also I should see the number jump to 1 from 0 at 2.8 sec, because I reset the timer at 1.8 sec.

The actual result of your code is that I will see the number jump to 1 from 0 at 2 sec instead of 2.8 sec.

Normally I don't talk about this issue, since you are good for the basic, I think it's good to let you know this.

Have a try if you have time

You can try to implement the timer just using setTimeout instead of setInterval.

Glad to see you implemented the date process part yourself :)

Normally for Date/Time operations we don't do it by hand cause there is one standard library to do help us, check out moment.js: https://momentjs.com