yiisoft / cache-db Goto Github PK

Good day. I have next case:

1. Some external paid API with limited requests per time
2. The parts of the methods from this API free for use (like version, data-version, balance etc)
3. I cached paid results from this API using cache-db (to be independent from reboot of production machine). It's ok
4. Today i start using TagDependency with tag equals $api->dataVersion() and i have fail with $value['data'] is resource instead of string and it cannot be unserialized. But it's still works without dependency

DB - PostgreSql 14 with bytea data type

https://github.com/yiisoft/cache-db/actions/runs/6170723751

• Adopt package to psr/simple-cache to ^2.0|^3.0.

Good day. CacheDb have two constants

private const TTL_INFINITY = 0;
private const TTL_EXPIRED = -1;

and method

private function normalizeTtl($ttl): int
    {
        if ($ttl === null) {
            return self::TTL_INFINITY;
        }

        if ($ttl instanceof DateInterval) {
            return (new DateTime('@0'))->add($ttl)->getTimestamp();
        }

        $ttl = (int) $ttl;
        return $ttl > 0 ? $ttl : self::TTL_EXPIRED;
    }

But if i send 0 as $ttl (TTL_INFINITY), method returns -1 (TTL_EXPIRED) from last condition where $ttl must be greater as 0;

P.S. maybe TTL constant create public? Then we can use it like

$cache->set($key, $data, $cache::TTL_INFINITY);