yhuard / ecl-example

Hi there 👋

ecl-example's Issues

Lint errors

Scope

When running npm run lint I get:

/Users/ademarco/Sites/atomium-project/web/sites/all/themes/atomium/atomium_europa/scripts/copy.js
   2:14  error    'fs-extra' should be listed in the project's dependencies, not devDependencies  import/no-extraneous-dependencies
  10:12  warning  Unexpected console statement                                                    no-console
  13:10  warning  Unexpected console statement                                                    no-console
  19:12  warning  Unexpected console statement                                                    no-console
  22:10  warning  Unexpected console statement                                                    no-console

✖ 5 problems (1 error, 4 warnings)

Tasks

• Fix this.

Modify ignore file

Scope

In Atomium theme we commit the dist directory to our repo so, if possible, we would need the .gitignore file to be modified in the following way:

# Temporary files
.tmp
*.css.map

# Ignore some folders
node_modules

# Logs
logs
*.log

# Editors
.idea
.c9
.env

Tasks

• Update ignore file

Add Tachyons

Scope

We need a minimal grid framework for the time being, we installed Tachyons as part of https://github.com/ec-europa/atomium/pull/9/files

Tasks

• Port changes in PR to this project

Do not specify Yarn as a dependency if not strictly needed

Scope

As core team we will limit frontend work to the minimum, trying to leverage the work done on the component libraries. Since we can do everything that we do with Yarn with NPM we were wondering if we could remove Yarn and related code from the boilerplate project.

Tasks

• Remove Yarn and related code
• Update README