yen / psrt.astra

PSO2 Patcher optimised for performance and stability

psrt.astra's Issues

Application exceptions are not being handled

Dialog box and pastebin of exception information is required

NullReferenceException when close MainWindow during Verify Phase

Astra Version: 2.0.5.0
OS: Windows 10 Education Version 1709 64-bit

Reproduce requires:
Astra Version: 2.0.5.0
PSO2: Complete (no missing file)

Reproduce:

1. Delete pso2.exe (to force Astra to redownload)
2. Launch PSRT.Astra
3. Setup PSO2 path if necessary
4. Click "Launch PSO2" button on MainWindow
5. Wait until "Verifying files" phase being processed
6. Click "x" (close) on the top right conner MainWindow
7. Observe pso2.exe being downloaded while PSRT.Astra run in background
8. Wait until pso2.exe download to complete.
9. PSRT.Astra crash without any graphical error message (nor prompt upload logs).

Expect output:
7. PSRT.Astra cancel download and exit gracefully.

Reason:

• MainWindow's Window_Closed doesn't handle launch cancellation

Proposal:

• cancel launch task properly when Window_Closed is called. (this may corrupt files are being downloaded will but is expected)

Extra:

PSRT.Astra/PSRT.Astra/Models/Phases/VerifyFilesPhase.cs

Line 83 in 1765740

Interlocked.Decrement(ref state.AtomicProcessCount);

Lack of information on the GitHub page - readme, contribution guidelines, changelog, etc.

First issue! First of all, thanks for this wonderful project. I have some questions and suggestions, and suppose I can break it down into four things:

1. The README.md file is almost completely empty. The thread on PSO World contains a screenshot as well as useful information about the project and why one would use it, so couldn't that just be copied into the README file? That would make it a lot easier for people to understand what PSRT Astra is when they visit the GitHub page. (It'd also be nice to know what "PSRT" actually stands for!)

2. I might be interested in contributing to this project, but I don't see any information at all about that. Usually there would be some details in the README file, or in a separate text file. For example, are contributions even accepted in the first place? Should people ask permission to work on something first, or just go ahead and fork and then send a pull request? Should an issue be opened first to discuss individual contributions before starting work?

3. There is a lack of information on the Releases page. All I know is that there was an initial release, then v1.1, and then v1.2 just a short while ago - but what actually changed? To find out, I would have to go through the commit log. It would be greatly appreciated if a changelog could be posted along with each release on the Releases page, to keep everyone informed.

4. As there are no previous issues for me to look through and learn from, I'd like to know: how strict are you with regards to the issue tracker? Is it okay to open issues to ask general questions or give general feedback, or should it be strictly reserved for bug reports? Different projects have different stances on this.

Sorry for bombarding you with all those questions. I hope that's okay, and that I'm not intruding or annoying. I'm very interested in this project and have high hopes for it!

this launcher uses a lot of Arks Layer's components

first of all, great project, love the simplistic design.
i want to contribute to this project but there are a couple holding me back:

• it depend on many closed source dlls to be standalone.
• is this project associate with arks layer somehow? they seem very protective about resources, do you have permission to access theirs stuff?

thank for the open source project.

Stuck on Verification

With the latest release Astra doesn't progress when verifying the last out of the files.

(Seems like it was a connection related issue, so closed.)

Arks Layer plugins not working

With the NGS / 64-bit engine update a while back, the Arks Layer plugins became broken. This was the case for all users, regardless of which launcher they were using. However, the plugins have recently been fixed for PSO2 Tweaker users, as of a few days ago. Sadly, they are still broken with Astra for whatever reason. When launching the game, Astra reports that "An error occurred while verifying the Arks-Layer tools". It would be great if this could be fixed soon, or at least before the NGS release on the 9th. Thanks.

It is not necessary to keep Astra to keep running after launch pso2

This behavior a little bit against the lightweight claims of Astra. Understand that keep Astra around so it doesn't need to recheck every launch but recheck doesn't take too much time and not very frequently.

Proposal:

1. Keep running as default behavior and provide an option to "Exit Astra after launch PSO2"
2. Exit Astra after launch PSO2 as default behavior and provide a mechanism to "Force lauch, skip integrity check" (e.g. hold Ctrl for 3 seconds)
3. Both 1. and 2.

These implementation will of couse make Astra a little bit more complex but provide user more options and convenience.

Mod files being written twice on launch

"I have some mod files in the mods folder. I've noticed that when I run Astra, it seems to copy the mod files, then update those files back to the original ones, then copy them again. This makes the start-up process take a bit longer before I can launch the game. Perhaps I'm misunderstanding something and might be wrong, but it seems like it's maybe doing the steps in the wrong order? See here for a screenshot of the log to explain what I mean."

Patcher thinks my game files are outdated despite it already being updated via other sources.

Trying to use the patcher with an already updated version of PSO2 forces it to queue 71k files to download because they are "outdated" (screenshot).

An option to force the patcher to skip the file check and label the current files as "updated" would solve the issue.

This is my first time submitting an issue here so sorry if I'm doing something wrong.