yellowbluesky / pixivformuzei3 Goto Github PK

This command shamelessly copied from BingImageOfTheDay, it's a nice feature

Should not be hard to implement it into this app.

Relevant code in here

Hi, recently I moved from galaxy a5 2016 (stock) to Xiaomi Redmi Note 4X with custom ROM (Pixel Experience - Android 10)

Sadly the app now seems to not be able to download any images (After selecting it in Muzei nothing happens). Dahlia's pixiv app works just fine so it's nothing related to Muzei itself. I tried version 2.6.1 (from play store) and 2.4.5 (from github) and both had the same issue.

---EDIT---
I just saw issue #49 and after doing what NarihiroCH did in his last comment app does work. I'm going to test it a bit more.

After allowing NSFW art app still downloads images (gallery gets bigger)

After ticking auto cache clear at 1AM app still downloads images (gallery gets bigger)

After ticking external storage app seems to not download any images (gallery size stays the same)

After disabling external storage app downloads images once more (galley gets bigger, I also cleared cache just to see if it redownloads old images)

At this point I went to check storage permissions and Pixiv for Muzei did have storage permissions but Muzei itself did not (and never asked for them but i allowed storage permissions manually, it didn't help anyway)

I enabled external storage again and cleared cache. After loading next image in Muzei it showed M logo for a while, then started iterating through informations about images only to later disable next image button, gallery has one image inside that doesn't get set as wallpaper even if I press it (Muzei states it did set it as wallpaper). I checked it again few minutes later and there was a new image that ended up being empty with some pixiv info attached to it. Seems like gallery slowly fills up with those empty images over time now. Muzei still has the next image button disabled, double click doesn't do anything.

Seems like there's an issue with external storage option (Android 10? or maybe just some specific roms?)

---Edit2---

I turned off external storage and 1am cache clear, cleared cache manually, app still doesn't download anything, button is gone, gallery is still full of empty images.

I reinstalled Muzei and Pixiv for Muzei, enabled 1am wipe and NSFW. Works fine, I disables 1am wipe. Works fine. Seems like if it starts to fill gallery with empty images that only have info attached it completely bricks Pixiv for Muzei.

have a non selectable preference, with some text and summary
android:selectable="false"

Is better practice, and allows updates even during Doze

Within their respective JSON's,

• Ranking has "rating_count" or "view_count"

• Feed/Bookmark/Tag has "total_view" or "total_bookmarks"

With the number of filtering options now available, I am now seeing in the logs that filtering is now often retrying for something that satisfies all conditions set

Things that I can do are:

• Loosen NSFW filtering (not a good idea)

• loosen aspect ratio filtering (will have an impact)

• Download an offset JSON

  • There is provision in the API to download the next 30 or 50 artworks. Implementation can be found here
    This option is the most robust, but will require a fair bit of rework to how my code flows

Ranking images only have two levels of NSFW filtering levels: images with and without the "sexual" tag set

This conflicts with the current set of NSFW levels which are catered for the auth update modes: there are four levels.

I can have another two fields in the array.xml, and in the activity call the necessary functions to change the entry and entryvalues as needed

Now that I have robust filtering and retry counting, I can stop using random and instead linearly traverse the artwork list

Especially applicable for Auth feed modes, where I can simply request a new offset JSON.

For ranking feed modes, as there are no offset JSONs available, filtering restrictions will need to be gradually relaxed as iterate counts increase

As functionality grows, it becomes harder and harder to test all permutations of app settings

Worst offenders of being a large function include:

• doWork()
  • Spawn two child functions, one for feed and one for bookmark
  • Maybe even allow the child functions to insert the pictures into Muzei's database (addArtwork())
• getAccessToken()
  • Separate functions for logging in with username/password, and for using a refresh token
• selectPicture()
  • Split into two functions, one for feed and one for bookmark

Is there a way to open the origin page on pixiv?

Issue thread for information gathering on app no longer working

Worker does not trigger at the specified time, all artworks are still present

particularly the strings in SettingsActivity that toast of new filtering or update mode

Authenticated update modes work, but after a while the update mode on its own accord becomes daily_ranking

Code is getting hard to follow and understand
e.g. every child function creating a SharedPreferences object of their own

Pass the required parameters instead

A one time toast message perhaps

An internal flag storing whether the user has been toasted yet

other.mode useless,hope dev this new mode.thk

currently we are having to use username / password auth every time

Daily ranking updates everyday, however the images often continue to display well into the next day.

This can be solved by having a button where the user can manually clear the image cache, or by tagging each image stored with its expiry date

Would you please publish this app on F-Droid? Thanks!

I'd like to get wallpaper fit my screen or only part of the image can be display. Would it be possible to filter image by aspect ratio (e.g. width:height < 1)?

Inelegant, brute force way to force the app to start working again after it hangs on cache clear

Tested with latest build in branch autoClearCache 1fc8c3c

Could you please add an option showing only higher NSFW filtering level images?

To check if Muzei is installed:
https://stackoverflow.com/questions/18752202/check-if-application-is-installed-android

To open to Muzei Play Store listing
https://stackoverflow.com/questions/11753000/how-to-open-the-google-play-store-directly-from-my-android-application/11753070#11753070

Cache daily rank JSON for 24 hours, weekly rank JSON for 7 days, monthly rank JSON for 30 days.

If expired simply acquire a new one.

Delete the cache and do not use one if switching to/using feed, bookmark, tag, or artist modes

Will probably need some sort of serdes, maybe Google protobuf? Will need much more research

It is currently on APPEND, and I am seeing some odd cases where the app stops working when cache is cleared or when mode changes

Changing it to KEEP may help with this.

Downside is the fact that pulling many images at once (on change mode or cache clear) will be much slower

I'm new to pixiv and this app and I'd like to show only "Force of Will" search images, how can I do this?
Thanks

It's able to open settings but can't change any backgrounds while it has been chosen in Muzei app. Neither In-app Background nor launcher background.

I suspect that the hardcoded folder path is causing issues in Android 10, especially with its filesystem changes that I do not fully understand yet

On inspection, while most downloaded images are under 1MB, a number of the imagesbeing downloaded are quite large; from 6 MBs up to 17MB.

Should be trivial if file size can be determined from Response body

When I enter the setting, I go to "Pixiv Login" and then I tap "Pixiv ID" and I put my id and then I tap the "Password" and I put my password then nothing happens, and in the bottom of "Pixiv ID" appears "Not logged in", I do something wrong?

Issue described in
muzei/muzei#607

Issue described and fixed in here upbit/pixivpy#83

Many thanks to upbit (developer of pixivpy) for their investigation and fix

Can check based on artwork tokens/ID. More logic to add to filter functions

Hide it in all the ranking modes.

Reveal it in feed, bookmark, and tag search modes

Add option to define the proxy like pixiv.cat

Display user profile picture

this also serves as a convenient way to indicate if authentication failed

I'd be nice to see an option for the app to save all downloaded images before removing them. It'd make my image hoarder heart happy

On an empty cache (from fresh app install or app requested clear), Muzei only queues and downloads two images.

A setArtwork(), then a loop calling addArtwork repeatedly should be an easy fix

also link to mine