yaraoprysk / flutter_movie_app

this repository contains my 5 hw lab for Flutter course | movie app using rest api & bloc pattern

Flutter Movie App

this repository contains my 5 hw lab for Flutter course | movie app using rest api & bloc pattern

flutter_movie_app's Issues

Lab 5 review

@yaraoprysk overral it's an impressive piece of work. The app has this "production" look and it's obvious that you've invested a lot of time in it.

Initially I didn't plan to give your more than 12/20 because of overdue deadlines (you did it twice actually), but after seeing this app I think it would be unfair, so you have 15/20 instead. Good job.

The issues to fix:

1. 
   don't store API key in repository, for replace it with some placeholder, push to github and locally replace it with the value when you run the app

2. Don't make subjects in your BLOC public: the consumer only needs to know about the sink (input) and stream (output), and the fact that we use subject for that is an implementation detail

3. You have a lot of similar methods in your repository.dart. The only differences are the URL you use and type of response. You can create some generic version, pass url and response type in it, and have a single method to call all the APIs