yakimych / lift-log-react-ts Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 0.0 3.64 MB

Frontend for LiftLog

HTML 0.90% CSS 2.77% TypeScript 95.92% PowerShell 0.32% Shell 0.10%

lift-log-react-ts's People

Contributors

Stargazers

Watchers

lift-log-react-ts's Issues

Show error message if a network call fails

E.g. if the WebAPI is down, and the user is trying to add a log.

Assign RPE to a set

It should be possible to enter an RPE value for each individual set.
Valid RPE range: 6.5-10.0 with 0.5 step (e.g. 7.5 is a valid value, but 7.6 is not).
Design considerations: since RPE is optional and is to be rarely used, it should preferably not clutter the user interface.

Add possibility to add one or more links

One option would be to add links to e.g. a youtube video in the comments (#3), but it would be more user-friendly to be able to make it into an tag with a possibility to click it.
This should be considered from a UX perspective, since it might be challenging to fit fields for links and a comment, as well as sets/reps with RPEs in the same dialog.

Validation

Comment max length: 400
Link Text max length: 20
Link Url max length: 200
Max number of links: 3

Improve flow for adding log entry

Background

The current flow is somewhat confusing, since nothing is added when clicking "Save" in the dialog. The user is rather expected to click Add afterwards.

Suggestion

Remove the Edit button
Open the dialog when the Add button is clicked
Add the entry if the user clicks on Save in the dialog

404 when attempting to add an entry with a trailing slash in the url

Go to http://liftlog.se/benchpress/ (trailing slash)
Try to add a lift entry

Expected: Entry added.
Actual: 404 in the API request.

Improve RPE input

Problem

The only way to assign an RPE value to a set is to use the "Reps@Rpe" format. This is not user-friendly and neither is it easy code in a structured way.

Solution

RPE should have it's own input field

Note

Since it's rare to assign RPEs to a set, it shouldn't take space by default

Name and weight should be mandatory (the Add button should be disabled unless all fields are filled in).
Name maxlength should be 30 characters.
Weight should be a valid decimal between 0 and 999.

Show graceful error page when log does not exist

Currently "Loading..." is shown forever and errors are printed to the console.
A 404 or "Log does not exist" page would be a nice alternative.