yahooarchive / yangmingshan Goto Github PK

I want to pick multiple videos and record video, is it possible for this library ?

Cancel button that invokes photoPickerViewControllerDidCancel: delegate method is invisible while the YMSPhotoPickerViewController is present on screen. It is tappable and calls the corresponding delegate method properly. But it is only visible for the duration of click (tap). Look at the screenshot below to understand the scenario.

Hi found an issue when using camera to take images.
Tested on iOS 11 iPad.

Steps.

1. Open picker
2. Press camera symbol and allow access.
3. press cancel to go back to the picker.
4. press cancel to go out from picker
5. Now ui freeze about 1-8sec

Same thing happens also if you on step 3 take an image and "use photo" when it goes back to picker it will be freezing UI.
Any1 know how to fix this issue?
Thanks!

Happen in:

• iOS 8.4

Steps:

1. Open photo picker.
2. Select camera.
3. Take picture.
4. Press use photo => Nothing happen.

I found that delegate

• (void)imagePickerController:(UIImagePickerController *)picker didFinishPickingImage:(UIImage *)image editingInfo:(nullable NSDictionary<NSString *,id> *)editingInfo;
  not called.

It called delegate:

• (void)imagePickerController:(UIImagePickerController *)picker didFinishPickingMediaWithInfo:(NSDictionary<NSString *,id> *)info {}

Please check!

I had implement library on swift 3 and app crash affer enable photos in setting with error "_BSMachError: (os/kern) invalid capability (20)" and "_BSMachError: (os/kern) invalid name (15)" . How to fix it?

HI :) , Thanks for your source code, in use, I found a problem

1. First select a cell, and then just press the selected cell, open (YMSSinglePhotoViewController.m)
2. Click navigationItem.rightBarButtonItem@selector (selectCurrentPhoto :), after the previously selected cell count will increase once more
3. I think maybe need (YMSPhotoPickerViewController.m) function - (BOOL) collectionView: (UICollectionView *) collectionView shouldSelectItemAtIndexPath: (NSIndexPath *) indexPath, add a condition
   if (cell.isSelected == YES) {
       return NO;
   }

Sorry, my english is poor..... ㄒ_ㄒ

I got error like Error Log.txt.

Case :

• Take Picture from Camera
• Single Picture pick

I just implement it using yms_presentAlbumPhotoViewWithDelegate like your example

deletePhotoImage Crash
When I change the UICollectionViewDelegateFlowLayout code:

Changed Code
return CGSize(width: collectionView.bounds.width/4, height: collectionView.bounds.height/4)

Origin Code:
return CGSize(width: collectionView.bounds.width, height: collectionView.bounds.height)

In case the device is out of storage, some/all photos might not be downloaded yet, and the photo list might be empty.
The solution is below:
https://gist.github.com/duannguyenle/c9f525a013a145b81918c843b512631d
Can you take a look and fix it? Thanks.
Have a nice day :)

Hey

I am trying to do retain of selection of images which were selected once and again when i again choose images at that time selected image i have to again select for example ,
first i choose 3 images and then again i want to add another image then i am not able to retain previous image so i have to again select those image which i had selected. Can you suggest me what should i do ?

I'd like to be able to specify font in:

• The album cell
• The photo cell
• The title in the navigation bar

10.3 on a 7+
After accepting the photos permission, I am left with no default album selected, just a arrow at the top and no images showing.

I can select and album afterwards, but many users may not see that little arrow. It is inconvenient.

I try below code; however, it doesn't seem to have any effect as there seems to be no navigationController:

pickerViewController.navigationController?.hidesBarsOnSwipe = false

navigationController is nil actually. So is there any other way to disable the hiding of the navigationBar?

Hi there,
First of all, thanks for awesome project
Any chances we can add an option to disable saving function after taking a photo? For example, we don't want the photo was taken will be seen in anywhere but our application. The reason is for security.
Thank you and have a nice day :-)

When picking 1 image the picker UI dismisses immediately after selection and does not invoke the delegate didFinishPickingImages handler.

        let pickerViewController = YMSPhotoPickerViewController.init()
        pickerViewController.numberOfPhotoToSelect = 1
        ...
        viewController.yms_presentCustomAlbumPhotoView(pickerViewController, delegate: self)

When the project has multiple targets and different images for different targets.
This repo will make all these .xcassets files lose efficacy, and all targets will use one target's images.

I have created a demo for this situation.

In init commit , everything is OK, but all install YangMingShan commit (need pod install) the app show error images.

Hey there,

Some images in picker appear completely white in picker. After looking into it, I noticed those images are not loaded from iCloud Photos yet. And when I select white image (not loaded) in picker. App crashes when I try to convert it to UIImage.

This is how I convert assets to UIImage normally.

static func getAssetImage(asset: PHAsset) -> UIImage? {
        var pickedImage: UIImage?
        let manager = PHImageManager.defaultManager()
        let option = PHImageRequestOptions()
        option.synchronous = true
        
        manager.requestImageForAsset(asset, targetSize: PHImageManagerMaximumSize, contentMode: .AspectFill, options: option) { (image: UIImage?, info: [NSObject : AnyObject]?) in
            
            pickedImage = image
        }
        
        return pickedImage
    }

Is there any way to work around this?

I noticed this when running my app (which uses YangMingShan) on a friend's phone. She has a lot of photos in her camera roll (~20000), and when I press the the button to open the photo picker, the app freezes for a good 2 seconds. I reproduced it by make 20000 copies of a uiimage on my own phone.

Is there anyway to limit the number of photos that are loaded initially and then paginate if the user ever scrolls that far?

Is there anyway to implement this into my project without using CocoaPods?

HI,

    for (PHAsset *asset in photoAssets) {
        CGSize targetSize = CGSizeMake((CGRectGetWidth(_mycollection.bounds) - 20*2) * [UIScreen mainScreen].scale, (CGRectGetHeight(_mycollection.bounds) - 20*2) * [UIScreen mainScreen].scale);
        [imageManager requestImageForAsset:asset targetSize:PHImageManagerMaximumSize contentMode:PHImageContentModeAspectFill options:options resultHandler:^(UIImage *image, NSDictionary *info) {
            [mutableImages addObject:image];
        }];
    } 

Th above method is not working in iphone4.suddenly it's not working.Please kindly suggest me how to resolve this issue and it is important for me.

Thanks inadvance

Hi. I get error when running YMSPhotoPicker in iphone X.

I was I tried selecting images that I took using the camera cell and some are not loading properly.
Is there a problem with saving the images to the phone photos? Is this possible?

I am using this control in my app and now for ios 11 iPhoneX i am facing problem in navigation bar as it is not properly used in iPhoneX simulator, so can it be possible to fix this issue. Thank you

Hi,

Is there any possibility to disable the camera and allow a user to only select images?

Isn't there any way to select both images and video ?