yacgroup / yacguide Goto Github PK

We just removed the back buttons from all views (#82).
However, a recent research showed that not all phones have a back button.

We need to clarify about re-implementing this functionality.

Comments and opinions welcome.

Currently, the ascend styles "seen", "visited", "heard" are not shown in the tourbook.
I would suggest to remove them. They don't have anything to do with a climbing guide or tourbook but rather with making public comments like on sandsteinklettern.de.

If such a style was imported from sandsteinklettern.de tourbook, we would simply omit it.

Edit: Conversation concluded. See adapted issue title.

sandsteinklettern.de returns null if there is no element in a region, sector, ... Change the behavior that null is not treated as an update error

To handle possible database format changes in the future, I propose to implement a format version for the database. With this feature it is possible to find out what database version is currently running and a conversion of the existing database is possible.

For #57 to provide a good user experience, the map should have few settings:

• management of downloaded map material
• progress for map download

Note: Since we don't have unit test, the app's behavior must not change by applying this PR!

If there are no botches or projects, the switch to these views does not work in TourbookActivity.

0. Change ascend style to the according styles on sandsteinklettern.de
   Export:
1. Write data of Ascend table to JSONArray
2. Write JSONArray to file (store publicly on external device of available)
   Import:
3. Read file to JSONArray
4. Replace data in Ascends table with the data in JSONArray

Use public directories for export and update apk

... containing e.g. sandsteinklettern.de as source of data

Just forward the according id via intent to next activity

To improve compatibility with different storage types (i.e. locally, cloud storage etc.)
The FileChooser should make use of the Android Intents: ACTION_GET_CONTENT, ACTION_CREATE_DOCUMENT, ACTION_OPEN_DOCUMENT

also see:

• https://developer.android.com/guide/topics/providers/document-provider.html
• https://stackoverflow.com/questions/36557879/how-to-use-native-android-file-open-dialog

Derive version from Git using e.g. the Gradle plugin https://github.com/gladed/gradle-android-git-version.

I suggest to have two items here for Export and Import, respectively. Doing so, we can get rid of this annoying in-between-Dialog Import/Export.

Originally posted by @paetz in https://github.com/_render_node/MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzE5MDAzNjQ1/pull_request_reviews/more_threads

Should be case-insensitive.

Add a custom setting to define a custom color for lead- and follow-ascends, respectively.
Default should be (as it is now) both green.

The settings might be stored in a SharedPreferences object.

HTTP request need an additional security config in the manifest.

The fix is already prepared, but needs to be separated from #61 and #57

Please add an information Toast if there were no remote objects to download when synchronizing a region/sector.

At the moment, both, the Java package and application ID are named com.example.paetz.yacguide. Rename both to the more generic name com.yacgroup.yacguide. For the F-Droid store (see #68) a unique and stable application ID is necessary. Therefore, the renaming should be done as soon as possible.

In the custom settings view, the user may decide how to count rocks regarding ascends, e.g.

• do not count anything (default)
• count only summits that contain a route the user led
• ...

Add the rock counter (e.g. (13 / 25)) behind the sector names.
The settings might be stored in a SharedPreferences object.

Route status is an int value like on sandsteinklettern.de. Check the meanings there.

ToDo:

• Add an item to the menu
• create an empty "Custom settings" view on click (we gonna fill it step-by-step in further issues)

Add more ascend information on summit and route level to enable more flexible name decoration

For an open-source project, I think there should always be a license. Just to avoid discussions and problems with contributors.

Update error "Fehler bei Aktualisierung" is not very helpful. Add the json exceptions message with a hint to contact the yacguide maintainers.

Since there are no comments for countries available, remove the info symbol from the menu bar for the country and the region view.

You will need to add a new xml layout, similar to the normal table menu layout, just without the info button.

The problem is that the encrypted variables, which are necessary for signing the app, are only available if the contributor pushes a branch directly to this repository. For PRs from forked repositories, the Travis CI will not decrypt the variables for security reasons. See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions for a detailed explanation.
We need to split the signing process from the normal CI run and do this only during deployment otherwise the CI will always fail for such PRs.

If a route is marked as project, the date makes no sense and should not be evaluated. Especially in the tour book, if no date is specified, a 0 is shown what it is somehow confusing.

The used HTML parsing is slow and error-prone. As soon as Joe offers JSON-formatted DB content, change this to downloading and parsing the relevant data from those JSON-formatted content.

Place .apk at release/alpha/.apk

This is a little bit confusing, if a summit that the user has not been climbed yet but one route is marked as projects, will be marked as climbed (green color).

I think it is more comfortable to have the last entries first. The other solution would be to make it sortable.

• add class/template for ascend style to prevent if-else-branches regarding ascend symbols
• add "Säcke" list
• rename "Merkliste" to "Projekte"
• add list type to TourbookActivity start parameters and decide about content based on this (currently "_isTickList")
• remove ascend symbol from TourbookActivity
• store ascended/sacked/watched/projected info in Route db field ascendCount using binary digits and remove iterations over ascends in RouteActivity, RockActivity, TourbookActivity
• create new version directory and build new .apk

Wherever possible, use final for variables

I propose an abstract picture of a Yak animal.

Use part of your big OSM pull request

There should be no binary files inside the repository. Especially the .apk file should be removed. The build and deployment of this file should be done by the CI service.
A suggestion for a simple flow would be as follows:

• Use the CI to automatically build and deploy a development version every day from the master branch, if there was a commit/merge since the last run.
• For official releases the maintainer must create a release tag which than triggers the CI again.

Official releases should follow the semantic versioning schema.

Please ensure:

• compatibility down to Android 5.1 (--> build with API level 22)
• correct app signing (use the key from apk_signing_passwords.txt in the root directory)

In the PartnerActivity the partners should be sorted by the number of ascends you have done with them.

Before the first official release, the files keystore.jks and apk_signing_passwords.txt must be removed and the signing passwords must be changed. Otherwise somebody can create another app which looks like this from Android point of view.
We must change it before the first official release because otherwise users, which already have installed this app, cannot update.