xuwei-k / grpc-scala-sample

translated from grpc java examples with ScalaPB

gRPC scala sample

grpc-scala-sample's Issues

Instructions how to run client and server

First of all, thank you for creating this repo. It has really helped me understand the usage of scala in grpc applications.

Nevertheless I've been struggling to get the HelloWorldServer and the HelloWorldClient to run. Although admittedly I'm a scala newbie, I think this repository would benefit with a description on how to do that, just like it is done in the case of the grpc-java examples: https://github.com/grpc/grpc-java/tree/master/examples#-to-build-the-examples.

I also tried running them in the interceptor branch but couldn't.

I tried running:

• sbt run
• sbt run io.grpc.examples.helloworld.HelloWorldServer
• sbt "run-main io.grpc.examples.helloworld.HelloWorldServer"

Even though show compiledMainClasses finds these: io.grpc.examples.helloworld.HelloWorldServer and io.grpc.examples.helloworld.HelloWorldClient

Could you shed some light? Thanks in advance!

Unable to build channel

I am getting following error

Error:(20, 87) value build is not a member of ?0
        val channel = ManagedChannelBuilder.forAddress(host, port).usePlaintext(true).build

for this line

https://scalapb.github.io/grpc.html has a breaking link

https://scalapb.github.io/grpc.html links to https://github.com/xuwei-k/grpc-scala-sample/tree/master/grpc-scala/src/main/scala/io/grpc/examples/routeguide
but it doesn't exist. I think it is not implemented yet?

So, making an issue to scalapb team or implementing a route guide example is better for scala(pb) beginners.

ExecutionContext for bindService and for ServerBuilder

Hello!
In this line you pass executionContext only to GreeterGrpc.bindService but not to ServerBuilder which is possible by calling .executor(..) on ServerBuilder.forPort(HelloWorldServer.port) (source).

You did that for a reason or it was just for the sake of example? What is the best practise here: these two thread pools rather be the same or separate?

Need guidance on implementing grpc

@xuwei-k and @tayama0324 can you show us a few hints on where to look for the code for implementing grpc on our project. Thanks a lot for this excellent work.

Project doesn't compile

If I checkout from master and run sbt compile I get a long list of errors....