Coder Social home page Coder Social logo

engagetimer's Introduction

I do things for stuff I'm passionate about. Can be personal projects, web apps, stuff.

I don't really have anything special to say or show off, but this README.md thing looked fancy, and even though my avatar depicts my hrothgar character from some final fantasy game, I'm a bit of a crow that likes shiny tings sometimes.

engagetimer's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

engagetimer's Issues

When showing decimals, countdown timer is 1 second behind

When the setting "Display decimals in countdown" is enabled, the Ones column of the countdown value should be reduced by 1 to account for this.

Example:
https://user-images.githubusercontent.com/68185248/133959967-41dec332-b294-4192-8921-00a3a2c61b90.mp4

When the countdown usually ticks and shows "5", it is now showing "5.0", then "5.9", "5.8", all the way until "5.1", then it ticks down to show "4.0", then "4.9". If you take the point in time where it's showing "4.9", the countdown is actually at 3.9 seconds... Because 0.1 seconds after the 4 shows up is 3.9 seconds, not 4.9 seconds.

To account for this, the when the vanilla game countdown hits 5, the countdown timer should instead display 4, and then the current decimals that are already in place in the current version. All that is needed is to decrement the big number (ones column) by 1.

Text Size

Hello,
First of all thank you for making this plugins it help a lot when it comes to not early pulling :)

I was wondering if there's a possibility of resizing the text and drag it around and if not is it something that can be considered in the futur ?

Regards

Countdown color

Feedback for EngageTimer
Please let me change the font and color of the count down.
Dalamud commit#
9039e06
2.0.0.1•11/10/2021

  • Styles are currently implemented to remedy to this
  • To do : add a color tint option if possible

Can not enable decimals without enabling big countdown

Right now Enable big countdown acts as the Enable button for all countdown drawing features. This means it's not possible to simply enable the decimals/accurate countdown or change the number style without adding numbers before 5. Would be beneficial to allow us to enable other feature without requiring the full countdown to be shown. Even better would be to add a custom point to start displaying the countdown timer. This would allow for players to set up the timer based on what's useful for their classes pre-pull.

Option to draw main 0-5 without hide original countdown

image

Currently, main numbers under 6 don't show and only decimals show. If the user wants to see 5.9, etc., they have to hide the original countdown. However, I would like to keep the original countdown (so it looks vanilla in OBS Game Capture), ignore it, and use the plugin countdown positioned in a different location, necessitating that the plugin displays 5.9 and under properly.

option for different ticks on timer?

hi! I was wondering if there was a way to make it so (or if you could add the option to) you can set the countdown tick sfx (that in vanilla starts at 5) to be at a specific time on the countdown. it seems like there's only an option for the entire countdown or vanilla but I would love to be able to start it at 10s (even when the countdown is longer). thanks! :)

CD overlay can overlap with the in-game one when starting&cancelling

From discord (Kanaris)

Oh btw @xorus this was an issue from long before EW, but i never got around to making an issue ticket for it.
The engage timer countdown bugs out and overlaps with the vanilla game one if you start and cancel a countdown, or if you wipe during a countdown (from someone messing up prepull, for example). Actually I can't remember which of these it is, or if it is both, but it's worth looking into both of them. It came up many a time during TEA prog.
oh to clarify, it overlaps on the next countdown, after the one where you cancelled or wiped

FPS drop when plugin is enabled

*copied here so I don't forget*

Message from Darktalon on goat place discord:

@xorus im sorry if this is not the right place to report bugs, but i consistently lose fps in crowded places when i enable EngageTimer Addon, i have ONLY display countdown enabled
typically 4-5 fps drop between enabling or disabling this addon
tested this with every other plugin disabled first

Configuration
image

Testing

Issue reproduced by disabled all plugins except mine in Limsa. FPS dropped by 3-6 frames (sometimes it did not though).

  • Disablingdrawing regions of the plugin code did not improve the situation
  • Does not happen in empty areas like a house (stays at 162-163 fps)
  • Disabling the memory hook improves the FPS (not sure)
    • this feature is the basis for the plugin, and I do not know how I could improve this. Maybe find another ways to get the memory pointer ?
  • Does not happen with other plugins
  • 2021-08-10: while trying to work on the problem, I could not reproduce it anymore -_-

Split stopwatch/countdown windows ?

I am not sure if this would be useful as I received feedback from people expecting it, but none asking for it. It would be a pretty big rework :/.

Stopwatch is fucked up: ":" symbol is gone.

Where did it go ???
Top teams are investigating.

More news at 5.

--

Seriously though, maybe some font stuff is going on again with Dalamud, I'll look into this when I can.

Closes the game after a certain time

Hello,

Since the update, whenever a timer is started, it closes my game without throwing any error message after around 5-8s (nothing either in dalamud.log).
I tried various settings, resetting them and even launching a fresh dalamud install with only this plugin installed, and nothing seems to fix this :(

Any idea what might be causing it?

Multi-monitor compatibility

From Dalamud Feedback:

Background transparency of floating window is not available when multi-monitor window is enabled.

"Hide original countdown" setting makes original timer flicker

Hey there, thanks for your work on the plugin!

I've noticed that even with the "hide original countdown" setting enabled, the original timer appears for what feels like a single frame, making it flicker onto the screen. It's kind of annoying/distracting, and seems unintended.

I can get footage if needed, but it should be pretty straightforward to repro.

Sound ticking problem

Feedback for EngageTimer
After the most recent update a few days ago, it seems that the "ticking sound for all numbers" feature stopped working for me
Dalamud commit#
9039e06
Image
2.0.0.1•12/10/2021

Feedback for EngageTimer
Ticking sound no longer happens on numbers above 5, on API4.
Dalamud commit#
901c503
Image
2.0.0.1•09/10/2021

Better FFXIV style numbers

Feedback for EngageTimer

  1. Could you make the FFXIV style numbers a bit thicker or give them a drop shadow?
    They are a bit hard to read at times.
  2. Would it be possible to enable rescaling of the floating window, and to be able to disable the minus symbol:
    ex: -5.99, able to remove the - sign to make it say 5.99.

Otherwise top tier plugin, appreciate all the work! :)
2.0.2.1 • Aujourd’hui à 19:14

(Thanks for the kind feedback!)
Fun thing this pops up right now, I just spent all my afternoon cooking this : 2eabf92 !

  • Default style looks closer to the original numbers
  • Animation option mimicking the original one
  • Hue/saturation/brightness or color replace option
  • Scaling option
  • Proper bottom align of countdown decimals
  • "Test mode" button to get an actual preview

I'm leaving this open until I release that with some other fixes :)

Feature request: potion window notification

Hi, thank you for this very useful plugin!

I'd appreciate the option to have the timer flash (e.g. blink and change color) at configurable intervals (e.g. from 06:00 to 06:20) into a fight. The use case for this would be to notify the player that it is time to use a potion in a high-end duty.

Floating window text align broke

Feedback for EngageTimer
Engage Timer v2.1.1.0 Degrade?
Floating window tab > Styling category > Text aling
always left align, not working Center and Right.
Dalamud commit#
e8f395b

I think it's been broken since a bit more because I did not touch that. Bug to confirm.
Maybe I need to rework this align thing, I never got satisfied with it.

Audio does not work on Linux

You might experience some crashes with the plugin on Linux because of the audio engine I'm using.
I hope I can get to fixing that soon, but for the time being, please disable this option :

image

If your game crashes before you can access the plugins settings, the entry is called EnableTickingSound in the JSON, and you need to set it to false.

Related to #31


Underlying problem: NAudio does not want to work on linux (can't test it by myself)

<se.12>

Lap feature

Create "laps" that reset the displayed stopwatch :

Triggering :

  • keybind
  • chat text
  • specified time

Then post in echo chat the duration of each lap/phase + total length.

Countdown quirks

List of things I want to improve:

  • ability to move the "start" text so it follows the countdown if it has been moved (or customize it, I don't know)

Note:

This list is just so I don't forget things, you can comment to challenge them but if you have a new idea please create a new ticket

Performance issues?

Leave a comment here with details about your settings if you encounter performance issues.

Note: a common performance issue with EngageTimer is Dalamud's multi-monitor option as it can create lag when opening plugin windows in some cases. However, the plugin has to create a borderless window to draw the big countdown.

Please make sure it is disabled in /xlsettings if you do not use that feature.

chinese server

Dear Xorus,

Greetings! I am Yuwuhuo, one of your plugin's users from China. I wanted to reach out and express our deep appreciation for the exceptional plugin you have developed. We truly admire the quality of your work.

I have noticed that the Crowdin platform for your plugin still lacks a Chinese translation submission. Therefore, I took it upon myself to personally undertake the task of translating the plugin into Chinese. I am writing this message to request permission to submit the translated "rex" files.

Please bear in mind that the English content in this message was generated using Google Translate, and there might be some unintentional offense or linguistic inaccuracies. I apologize in advance for any inconveniences caused.

My intention is to provide a more convenient and helpful experience for Chinese users through this localization effort. Your plugin has already brought tremendous convenience to our community, and I hope that my contribution through this Chinese translation can serve as a way to give back for all your hard work.

Thank you for taking the time to read this private message. I eagerly await your positive response. Once again, thank you for creating such an outstanding plugin!

Best regards,

Yuwuhuo

Off-by-1 error since 2.0.0.0

Since the mentioned update, the timer display has had an off-by-1 error. For example, if a countdown is started with a 20-second duration, the displayed timer will start at 21 seconds (or 20.999 - it's difficult to tell since 21.000 would only display for a single frame at most) and count down to 1 second, at which time it will display "START!"

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.