xoofx / antlr4ast Goto Github PK

The library does not contain a visitor pattern.

I don't have a personal usage for this as I'm only going to go through the lexer/parser rules manually for my use case, but if there is an interest, PR welcome.

There are a few classes that are not named correctly and should be changed in the next major version:

• LexerChar should be LexerCharSet

(Temporary list for now, might change in the near future)

As described in the ANTLR4 documentation, (...)??, (...)*? and (...)+? are nongreedy (lazy) subrules.

But the SuffixKind enum in Antlr4Ast names these suffixes as Greedy (which is the opposite of what they are):

Simply renaming the enum members would break backwards (source) compatibility, so I would suggest keeping the original names with the same value at the bottom (so that ToString prints the correct name), but with an [Obsolete("...")] attribute (and potentially an [EditorBrowsable(EditorBrowsableState.Never)] attribute to hide them from IntelliSense).