xmohammedawad / generatepassword Goto Github PK

Firstly, it looks like the array characters is commented out. Is this intentional? If not, you'll need to uncomment it to make use of it in the createRandomPasswords function.

Next, I noticed that the checkGeneratedPassWord function sets the disabled attribute on the generatePasswordEl element to false if the passwordOne length is greater than 10. This should actually be set to true to disable the button, as you don't want to generate a password if the first password is already longer than the allowed length.

I would also recommend setting a default value for the passwordOne and passwordTwo variables to prevent any errors that may occur if they are referenced before being assigned a value.

Lastly, it's good practice to wrap your code in a DOMContentLoaded event listener to ensure that the DOM has fully loaded before your JavaScript runs.

update the style with css grid

update readme with our readme template