setIndented(false) also removes new lines from text in views about htmlflow

[fmcarvalho]

Well, it seems the way we are providing the setIndentation for HtmView is not correct. The way HtmlDoc and HtmView work are completely different. Indentation in HtmlDoc is made though the oldest newlineAndIndent():

HtmlFlow/src/main/java/htmlflow/visitor/HtmlVisitor.java

Line 122 in 4aac871

public final void newlineAndIndent(){

Whereas HtmView is always built with indentation set to true, and later on render we decide wether we want to remove it. The bug is on the following lines from HtmlContinuationSyncStatic class:

String block = v.isIndented
    ? staticHtmlBlock
    : stream(staticHtmlBlock.split(lineSeparator())).map(String::trim).collect(joining());

We are wrongly removing all line separators. To fix that we have to remove this code. Also we have to change the way we were building an HtmlView. Basically, whenever we call setIndent(...)we have to run the preprocessing(...) from the scratch with the correct indentation flag. And to do it we need to keep the HtmTemplate function associated with the HtmlView.

Is not very complicated and I think it has no impact on performance because all that will be made to run on preprocessing. Moreover I never liked that if/else (i.e ternary) on HtmlContinuationSyncStatic.

However this refactoring includes a couple of steps and I need to review all this again. I hope to dedicate some time to it at the end of this week.

Thank you,
Miguel

[shimikano]

Thank you, Miguel, for your efforts 🙏

[fmcarvalho]

Solved on new release 4.2