Comments (3)
Well, it seems the way we are providing the setIndentation
for HtmView
is not correct. The way HtmlDoc
and HtmView
work are completely different. Indentation in HtmlDoc
is made though the oldest newlineAndIndent()
:
Whereas HtmView
is always built with indentation set to true
, and later on render we decide wether we want to remove it. The bug is on the following lines from HtmlContinuationSyncStatic
class:
String block = v.isIndented
? staticHtmlBlock
: stream(staticHtmlBlock.split(lineSeparator())).map(String::trim).collect(joining());
We are wrongly removing all line separators. To fix that we have to remove this code. Also we have to change the way we were building an HtmlView
. Basically, whenever we call setIndent(...)
we have to run the preprocessing(...)
from the scratch with the correct indentation flag. And to do it we need to keep the HtmTemplate
function associated with the HtmlView
.
Is not very complicated and I think it has no impact on performance because all that will be made to run on preprocessing. Moreover I never liked that if/else (i.e ternary) on HtmlContinuationSyncStatic
.
However this refactoring includes a couple of steps and I need to review all this again. I hope to dedicate some time to it at the end of this week.
Thank you,
Miguel
from htmlflow.
Thank you, Miguel, for your efforts 🙏
from htmlflow.
Solved on new release 4.2
from htmlflow.
Related Issues (20)
- View with dynamic and static attribute / Placement of dynamic() block HOT 6
- Inline SVG from string add to view HOT 2
- How to use For Loop / If condition / Map with HTML FLow? HOT 6
- Tags gets confused with text HOT 2
- Missing oncontextmenu and disable textarea whitespace HOT 6
- Typos in blog post HOT 2
- Documentation expansion HOT 2
- Gradle build warnings... HOT 5
- Groovy compilation errors ... HOT 4
- Security Scan Warning - JSOUP...? HOT 1
- Input attribute checked=false|true not compliant HOT 3
- Cannot have full dynamic page HOT 1
- Is there any idea code folding plugin recommendation? HOT 3
- slf4j-simple should not be declared as a dependecy HOT 2
- Multiple model with single template HOT 3
- option.attrSelected unexpected behavior HOT 7
- Enhance documentation with complete list of methods HOT 4
- Script tag, attribute type HOT 5
- Reflexion on template and java 21 features HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from htmlflow.