xdy / xdy-pf2e-workbench Goto Github PK

Random assortment of possibly useful doodads, thingumabobs and whatchamacallits for the foundry vtt pf2e system.

License: Other

Shell 0.22% TypeScript 94.76% Handlebars 3.73% SCSS 1.29%

xdy-pf2e-workbench's Introduction

XDY - Code Busker

Developer, mostly backend.
Nerd, mostly rpg:s.

When the items in the above list interact, some kind of nerdish software may be created or extended. Lately that's been mostly:

But I've also added - and subtracted :) - bugs and features in at least the following projects:

I've even done something non-software-related:

Setting Rule: Veritas for Savage Worlds

If you've enjoyed something I've created:

If you've not enjoyed something I've created:

No coffee for me. Bad xdy. :(

xdy-pf2e-workbench's People

Contributors

Stargazers

Watchers

xdy-pf2e-workbench's Issues

Feature Request: Effects expire out of combat, when toggle is enabled

Might be able to hook on updateWorldTime.
Potential considerations: Simple Calendar's setting that updates time every second.

Conflict with PF2E Attack Card Damage module

Ahoi.

When the experimental "Use mystified name in chat" option is enabled then PF2E Workbench breaks the functionality of the PF2E Attack Card Damage module. The latter still displays buttons in chat attack cards, but those buttons cannot be pressed/used anymore.

Feature Request: Random adjectives as an option instead of numbers for NPC Mystification

Is your proposal related to a problem?

Numbers as differentiators for multiple tokens of the same base actor are functional, but boring and more difficult to distinguish at a glance if the random numbers ended up similar.

Describe the solution you'd like

By adding random adjectives instead of numbers, different creatures are represented with effectively unique descriptors that are more interesting than just numbers. The Token Mold module offers an adjective-based approach (https://github.com/Moerill/token-mold#random-adjectives) and that part works very well, but it obviously doesn't support the trait-based mystification that you're doing.

So, for example, say I have an ancient red dragon actor I pulled from the compendium.

Today, I have Token Mold set up to replace the name of any unlinked token with a random adjective, completely obscuring what type of creature. So if I drag the creature to the map to create a token it will just get a random name, like "Treasured" (originally I wanted it to add "creature" so it would be something like "Treasured creature" but I couldn't get Token Mold to do that and it ended up not mattering - the random adjectives are fine standalone). My players will say, "I attack Treasured" or "I'd like to identify Treasured" instead of "I'd like to identify creature 29" and it's pretty solid. If they do identify them, though, I have to go back and manually rename the token, which is a huge hassle, particularly because the adjective is an effectively unique descriptor (the table has 4700 names) for them, so I basically just don't do it. I'll tell the players and maybe type the name of the creature in chat so they know how to spell it for their notes.

With the token mystification feature of PF2e Workbench, I'd like to be able to do something similar, but use the mystification features that are superior to complete replacement of name. So, for example, say I'm using the following NPC mystifier settings:

Mystify by NPC Traits
Word to prefix new name with: "Unknown"
Word to postfix new name with: [blank]
Add random number to name.
No random number for unique NPCs.
Keep token number when mystifying/demystifying.
(Experimental) Use mystified name inside chat messages.
No npc rarity in the name.
Word to replace rarities greater than common with: "Unusual"
No npc alignment traits in the name.
No npc traits not in the above trait types.

Today, if I have an "Ancient Red Dragon token" and I mystify it I might get Unknown Dragon 31. Pretty good, my players can tell it's a dragon, but not what type. If I demystify it, it's Ancient Red Dragon 31. Great! A few years ago, before I started using adjectives, this would have been all I could ask for.

If, however, a couple of settings were added/enabled (and I disabled the random number ones):

Add random adjective to name.
Source of random adjective list (e.g., a rolltable)
Position for random adjective [prefix | postfix]
Keep random adjective when mystifying/demystifying.

I could mystify the dragon and get something like "Unknown Swaggering Dragon" and demystify it to get "Swaggering Ancient Red Dragon" instead.

With adjectives, I might even leave them on for unique NPCs, because they're just kinda fun in general.

Describe alternatives you've considered

n/a

Additional context

You might ask: Doesn't a list of random adjectives mean you get some deeply stupid names for your creatures? The answer is yes. It's fun, though. Sometimes the names feel very appropriate ("Tyrannous" for a boss-level monster that the party learned ordered an earlier boss around), and sometimes they're entertainingly incongruous ("Neurological" for a big spider).

Link automatic initiative re-ordering to having the dying condition

Currently, combatants move initiative if they are reduced to 0 HP. This isn't ideal as it can lead to NPCs moving, which isn't necessary in most cases.

By tying movement to the dying condition, only PCs and NPCs that the GM decides to give dying will be moved.

Feature Request: Modify system's ABP behaviour to still allow item bonuses

Currently the system disables item bonuses of permanent items when using ABP. This is correct RAW, but it's a popular houserule to use ABP for its automatic runes and nothing else, keeping skill items. Such an option wouldn't fit in the system, but a module could do it

Rewrite mystification to store flags on tokens instead of just checking if name is changed

I.e. store a 'demystifiedName' on the token and set/unset this depending on state.
Should lead to simpler code.

Separate Auto-roll damage for GM and players

I would like to allow Auto-roll damage to be only for GMs and for Players to have to use the chat cards / character sheet to roll damage.

Ideally, it would like like the options below
World setting: "Autoroll damage for GM"
World setting: "Allow players to autoroll damage"
Client setting: "Autoroll damage if GM allows it"

Testing Bug Reporter

Core: 9.245
System: pf2e v3.3.0
Module Version: xdy-pf2e-workbench v2.21.8

Description:
If this issue is open, close it. :)

Active Modules

babele--v2.2.3;
bug-reporter--v1.3.2;
dice-so-nice--v4.3.0;
fr-core--v9.245.0;
lang-fr-pf2e--v3.3.0;
lang-sv--v1.0.1;
lib-wrapper--v1.11.1.0;
module-credits--v1.0.0;
pf2e-tweaks--v0.6.1;
tidy-ui_game-settings--v0.1.29;
xdy-pf2e-workbench--v2.21.8;

Additional Details

undefined

Make sure mystification can never cause the name to be just the empty string

Set it to "..." or something at the end if that has somehow happened.

[Feature Request] Sound Effect/Animation for Regular Successes

While Automated Animations somewhat cuts it with the animations, it plays the Primary Sound on every Roll, regardless of if it's a hit or not. This means when you have a sound set on a Crit Succ./Miss/Crit Miss, it overlaps with set Hit sound in Automated Animations. These animations/sounds are also weapon specific and not universal, which is something that'd be convenient to have (as in, universal Hit animation/sound effects).
A feature that adds a field where you can set a sound to play just when it registers a regular Hit would be very nice.

Error when using the play animation and/or sound feature

I’m getting an error when I try and use the play animation and/or sound feature. I’m on Foundry Version 9.255 and Pf2E 3.7.2.10818. I have the Sequencer module enabled and this is the configuration I have for the feature.

The sound plays when the players attack but they get this error message.

I see this error in the console too.

Hero Point Timer crash

First time that I bring up the Hero Point Timer UI it comes up fine, however after submitting a change the window will not reappear unless I reload foundry. The following error occurs in the console:

This is happening with v9.245. It was happening on PF system 3.2.2.x as well as reproducible on 3.3.0.10241.

When Mystifying on drag is always on, ever PC are mystified, could we have a option to make it for NPC Only?

Just this
Drag PC, Loot, ou Vehicles to scene when mystify on drag are on ALWAY could cause some troubles, so if it's possible to restrict it to NPC only I'll be glad.

Thanks for the good work, this mod really help me earn time!

Automatically move combatant non-functional

The following two features do not seem to be currently working.

Optional feature to automatically move combatant that goes to 0 hp to just before the current combatant. (See above.)
Optional feature to automatically move combatant that gets the Dying condition to just before the current combatant. (See above.)

Created a new world with only pf2e workbench enabled to make sure it wasn't a module conflict,

The manual keybind works fine however.

Verified with -
Foundry: V9.249
PF2e ruleset: 3.4.4.10487
PF2e Workbench: 2.26.1

[Feature Request] Have option for Prefix to stay with demystification

Similar to the Number Suffix, but instead have an option to keep the prefix. It lets you keep funny names from a roll table you may have set up even if they get demystify. Useful to differentiate enemies while being a little more whimsical than numbers.

[Request] Add a number or suffix to demystified creatures

I'd like to be able to demystify any creatures that they know about but when they do it would be ideal if they were differentiated from each other.

So for example a Corrupt Guard would be placed down/demystified as Corrupt Guard 1, Corrupt Guard 2 (or even with random numbers).

Empty settings set to null on save

When saving settings, all the entries that contain empty strings are set to "null" instead of empty.
This is causing mystification to result in "Null Animal 10" instead of the expected "Animal 10"

Manually changing the settings in settings.db to the empty string resolves the issue temporarily.

Feature Request: apply h3 collapsing to existing chat cards on world load

See title. I'd love it if when I start a world, the chat cards from last session(s) stayed collapsed. Or at least collapsible?

mystify "null" prefix - request

allow users to completely remove the prefix word. (eg Unknown)
If I leave it blank or put a space, "Null" is prepended to mystified names.
my workaround is to use "."

so the best I can get is have ". undead" ". aberration" etc...

null prefix

NPC Mystifier being applied to PCs

Hi!

I'm having an issue with the NPC Mystifier turned on by default: It's also being applied to PC tokens when I place them on the map.
Is there any way to disable the NPC Mystifier for PCs or Linked tokens?
I know Token Mold has an option to skip linked tokens. Maybe it's possible to make something similar?

And tThanks for the awesome work on this module! :D

Figure out why auto rolling for damage fails for some non-imported npcs.

Or does it fail for all non-imported ones?

[Feature Request] Animation and sound played on critical successes

Thank you for doing this module with several useful features!

I wanted to kindly ask if it was possible to implement the same configuration which exists for misses, but for critical successes as well, where they can be customised like it is already done within the module for misses. (a line for animation path and a line for sound)

Feature Request: No Number added to Unique Creatures

I'm loving this module, thank you! I was just wondering if it would be possible to add an option where numbers are only added to non-unique creatures? The addition of numbers is great, but it would be helpful to have it so that when a named NPC is mystified/demystified, it doesn't add a number to the token name.

Change autoroll damage to look at the message item instead of the flavor

game.messages.get("gxyAHjUJ4Bn0S9VA").item

Should fix the conflict with https://gitlab.com/Ustin/pf2e-tweaks, and be a lot more stable.
Or, hmm, the conflict with pf2e-tweaks is probably the way I find the roll result, not the way I find the item.
If needed, add special case code that handles it differently if pf2e-tweaks is installed.

Feature Request: Make option on a Prototype Token to Mystify on arrival

I would like to be able to have something like Monks Active Tiles create an actor that is already mystified.

Add an optional feature that handles flat checks

Like, check if target is one of hidden, invisible, etc that gives a flat check.
If so, either roll a flat check along with attack, or if that seems difficult, add a flat check button to the attack chat message.
I.e. in the first case the workflow would be:
Pick target, roll, which rolls a flat check the result of which is added to the message (with gm visibility), the gm tells you if you hit.
I.e. in the latter case the workflow would be:
Pick target, roll, if a hit, click the 'flat check' button which rolls a blind gm roll, he tells you if you hit.

Maybe differentiate between the different types of flat checks, some don't really need to be blind rolls.
Or, maybe, always do open rolls for flat checks?

Polymorph Spells and Auto-roll Damage

Attacks are using the wrong damage when autorolling.

Auto Expire Reactions

Got a suggestion for another feature. I implemented this in my own private module (along with the auto expire effects) but may be worth adding to your "bag of tricks" 😄

It doesn't seem the current system tracks Reaction timing very well, and so activating things like Quick Block and other reactions out side of your turn doesn't gel well with the timer.

Simple solution: at the start of a combatants turn, I look for any and all items that start with "Reaction: " and delete them. It worked well enough. I then just create Items Effects with a name like "Reaction: Quick Block" or "Reaction: Used" (to denote a generic reaction used)

It's a little heavy handed, and if we could get the devs to add either a checkbox like Sustained for "Reaction" OR add it to the Duration drop down (after/before Unlimited?) OR a third option to Expires On "Next Turn"? Just thoughts, not sure what the best way to denote it best.

feature request: ability to de-mystify

Great module! Thank you. Would it be possible to bake in an easy way to de-mystify an NPC, like after a PC does recall knowledge? Thanks again!

Mystification is renaming tokens to an original state

So the gist is that if a token had been laid down previously with another sequencing module (Token Mold for this instance), when attempting to mystify the token, it will change the name back to it's original name when placed, and then will allow the token to be mystified. Replication steps are per follows:

With the Token Mold module active and Workbench inactive, place a few tokens for reference with Token Mold's sequencing options enabled. Once token(s) are placed with a sequenced number, close the Foundry application, and then relaunch.
Following the same procedure as just performed, place more token(s) down and change the number that has been provided to the token through the token editor to a different number as they will initially follow a new order of sequencing.
Once a second set of tokens has been placed, activate the Workbench module (Token Mold can remain active or be in active, neither state affects this) and disable the options for numbers to be applied to tokens.
Select any token from the second set that was placed and the sequenced number changed, attempt to mystify the token. It will first change the current token name to it's original name, and then will mystify on a second attempt. When un-mystifying the token, the name will reappear as the original name that was initially given before any kind of changes were made.

There are no errors or warnings that appear in the console when this process is performed, and showing it in action would require the use of screen capture to record video of the instances occurring.

Option to Exclude Weak/Elite Templates

Currently there's such option to ignore rarity however there's no option to ignore templates.

Used localized version of traits in the Mystifier

The mystifier is really great, but does not use translated traits. It would be great if it could.

Add option to remove npc from combat tracker the round after it died.

I.e. don't remove immediately. (Maybe make delay configurable?)
This will break handing out xp via monk's tokenbar.

feature request: Add support for switching the iniative of dead pcs to just before whatever dropped them

I.e. in the damage-applying code or thereabouts, check if hp went below 0, if so change initiative to 'just before current initiative'. Does depend on the GM applying damage during the correct initiative, but, good enough I think.

Reenable the ability for GMs to autoroll damage for players

Make sure to test what happens if a character is owned by several players. Broke that too it seems.
Not sure how to fix that though.

Pull in Symon's macros and add them to the module

See discussion here: https://discord.com/channels/880968862240239708/880969174661353484/935827340217446400

Make a setting app

The current mess of settings needs sorting out.
One tab per feature I guess? (I.e. currently: mystification, moving combatants)

Add an optional setting to collapse chat message description

See https://gitlab.com/hooking/foundry-vtt---pathfinder-2e/-/merge_requests/4985 for a base implementation.

the auto collapse chat message description is not working

The item description can be collapsed, but it's not automatically collapsed by default.

Tested in a new world with only this mod installed.

Request: Chat card collapse should work for players too?

Currently is GM only, should be player also (configurable?)

Feature request:

Demyistify all for one, all tokens with the same base actor etc.

(Technically it'll be 'demystify all tokens with the same base actor', meaning that demystifying unique creatures of the same type, e.g. Gobbo the goblin that has it's own actor, won't demystify all regular goblins, nor will demystifying one of them demystify Gobbo. But, close enough to be useful I think.)

This is exactly what I had in mind.

Mystifier : no random number for unique NPCs not working ?

The setting does not seem to work

Add a feature that (per user) allows optionally automatically rolling damage after hit

Not applying though, just rolling.
Could probably take a look at how https://gitlab.com/mcarthur.alford/pf2qr did it.
Or perhaps better not, it has no license it seems.