xach / geometry Goto Github PK

Hi Zach,

In point.lisp there is

(defgeneric add/2 (a b))

Followed by

(macrolet ((define-point-op (name operation)
             `(defgeneric ,name (a b)
               (:method ((a point) (b point))
                 (point (,operation (x a) (x b))
                        (,operation (y a) (y b)))))))
  (define-point-op add/2 +)
  (define-point-op sub -)
  (define-point-op mul *)
  (define-point-op div /))

Technically it seems like this shouldn't break things, but mocl happens to be intolerant of redefinitions with defgeneric and it halts compilation with an error on the second defgeneric of ADD/2. This is really a mocl problem, but I thought since the defgeneric redefinition seems redundant anyway I would point it out in case you would like to get rid of it. As an added bonus, it would save mocl users some trouble too, for the time being. All you would need to do is delete

(defgeneric add/2 (a b))

Thanks,
Wes