wycks / wp-skeleton-theme Goto Github PK

Any chances to update this project to current responsive web design best practices?

http://bradfrost.github.io/this-is-responsive/

Will there be support for wide screen layouts? 1140px...1280px?

v1.1 is from 2011

Latest version is V2.0.4 from 2014 with code rewrite

Just from looking at the code, it seems that you copy/pasted the code and forgot to exchange the post type 'post' with 'page'.

Hi, great theme, I really appreciate the work you put into it. I've decided to add a page.php that is very similar to the full-width-page.php (but has sidebar) in order to have an easy to replicate template that is more familiar in structure, to what i am used to.

However, now I have two "Default Templates". I can change the name of the template for this page.php... and am stumped as to where the other Default Template (in page edit screen) is at. I believe it may be wordpress core. A plugin called Reveal Template shows that it is using page.php either way, and some breadcrumb code proves that this is the same page.php which I created. My theory is that the one "Default Template" is core, but refers back to the theme's page.php since it recognizes there is one.

I would like to remove the redundant page template from the page edit screen though, if possible. Any ideas?

Hello,

Since it's a standar, why not add

img {
max-width: 100%;
height: auto;
}

So big images won't overload its container?

I can make a pull request if you want.

Hey, good job so far with the theme just came across it and having a look through the code.

For WordPress best practice you should be enqueue'ing you scripts and style sheets through functions.php as opposed to manually including them in the head. This will allow plugins like W3 Total Cache to minify/compile the style sheets. This applies to scripts as well although slightly differently implementation see http://codex.wordpress.org/Function_Reference/wp_register_script

function load_all() {

    wp_register_style('skeleton-base', get_template_directory_uri().'/stylesheets/base.css', array(), '1.0', 'all');
    wp_enqueue_style('skeleton-base');

    wp_register_style('style', get_template_directory_uri().'/style.css', array(), '1.0', 'all');
    wp_enqueue_style('style');

    wp_register_style('skeleton-layout', get_template_directory_uri().'/stylesheets/layout.css', array(), '1.0', 'all');
    wp_enqueue_style('skeleton-layout');

}
add_action('wp_enqueue_scripts', 'load_all');

Hope that helps a bit and again good job so far :)

I've been using GetSkeleton for a while and am using this WordPress theme for the first time. It's much cleaner than Genesis.

As I bump into issues/fixes, where should I post them?

For example, it would be good to include a page.php file for sites that use a separate home page and don't want blog comments at the bottom.

function.php - the enqueue function should include an if statement so a child theme could override it.

style.css - Sidebar one-third needs to be more specific to allow one-third and two-thirds column widths in other places.

Hi!

Thanks so much for the theme. I'm having a couple challenges with it:

1. There are 2 javascript syntax errors which seem like they come from code built into the theme, since I found script in the theme files that is <script>paginateVal = ;"</script>:

Screenshot in Firebug console: http://internet-alacarte.com/wp-content/uploads/2012/03/Screen-shot-2012-03-15-at-8.15.38-PM.png

Error text:

"syntax error
paginateVal = ;"

"syntax error
paginateVal is not defined"

1. The shortcodes don't seem like they're not being parsed, neither in page content nor in the footer widgets.

Screenshot: http://internet-alacarte.com/wp-content/uploads/2012/03/Screen-shot-2012-03-15-at-8.15.47-PM.png

Thanks!
Alan

We need some screenshots and some demos of themes that use this framework. Please put the correct website address. The link is broken!

From looking at code for header/menu, it seems that you accidently left in a . between eleven.columns. Moving it out breaks the header, so I guess the eleven. should just be removed.