wt000 / bank-simulator Goto Github PK

The title explains itself

After assignment is marked, this can be fixed.

Make it so RegexCardValidator ensures added cards are validated, also ensure people can't leave fields empty

It would be better for it to be initialised with the attributes instead of using setters.

For instance, leaving the amount field empty or putting strings in it instead.

To fix this, values need to be checked before they're sent to the ReST server and ensure it's a valid double, otherwise it shouldn't do the ReST connection and tell the user to enter a valid value.

Perhaps a £ sign could be added to the left of the value too, ensuring people don't attempt to add that value in themselves.

Most of the layout is currently done in raw CSS, convert it to Bootstrap so it functions better.

This will be particularly useful for working on the fancier designs in phase 2 and phase 3.

More tests and logs are always good!

Find a way to hash the password if possible, do the same for cvv or simply remove the extra card details as they're not needed.

Some classes have been vastly changed, change the author names.

Self explanatory, the documentation needs to be worked on.

Currently needs to be finished:

Credit Card UI (Text UI, change limit system to work with variable length instead of numbers, see if date bug where clicking on date after credit card causes 1 extra input to be needed can be solved)
Conversion to Spring

This code should hopefully be done by Monday, giving time to do the documentation on Tuesday / Wednesday and finish presentations on Wednesday / Thursday.

Cards don't need to be added to the session, the form should only keep the card for the request. This also means that the card and transaction form can be merged in the future, making it easier for customers to perform operations (first checks form fields, then checks card with card checker, then uses ReST once it knows everything the user entered is validated).

The refund form on the admin page will work similarly to this, but only has customer card number and amount as fields (form only shows if there's currently an admin card in properties).