wt000 / bank-simulator

A bank simulator with REST capabilities.

Bank simulator

A credit card app powered by REST and built on Java Server Pages.

ae1 contains code and documentation related to our project.

APPLICATION SETUP

Firstly, ensure that you've got Java JDK 8 or newer installed on your system. You'll also need Apache Maven to ensure the application can build its dependencies and function correctly.

Once installed, navigate to the parent folder (ae1) and run:

mvn clean install

You can now deploy the web application using Tomcat. Furthermore, you could navigate to the web directory and run:

mvn cargo:run

After doing one of these, navigate to http://localhost:8080/web/ or http://localhost:8080/web/index.html for credits and a gateway to the running app! I recommend using a modern browser which supports JavaScript.

To access the admin control panel you'll need to enter "testuser2" and "defaulttestpass" if the default properties file successfully loads. If there's already a properties file with values inside it, the app will let you skip the login until valid properties are set.

DOCUMENTATION

• Click here to see documentation for the app.
• Click here to see tests against the use cases.

bank-simulator's Issues

Author names outdated

Some classes have been vastly changed, change the author names.

Finishing touches

Currently needs to be finished:

Credit Card UI (Text UI, change limit system to work with variable length instead of numbers, see if date bug where clicking on date after credit card causes 1 extra input to be needed can be solved)
Conversion to Spring

This code should hopefully be done by Monday, giving time to do the documentation on Tuesday / Wednesday and finish presentations on Wednesday / Thursday.

App crashes when invalid values are entered

For instance, leaving the amount field empty or putting strings in it instead.

To fix this, values need to be checked before they're sent to the ReST server and ensure it's a valid double, otherwise it shouldn't do the ReST connection and tell the user to enter a valid value.

Perhaps a £ sign could be added to the left of the value too, ensuring people don't attempt to add that value in themselves.

Owner password and cvv are stored in properties

Find a way to hash the password if possible, do the same for cvv or simply remove the extra card details as they're not needed.

Added cards aren't validated by our own application

Make it so RegexCardValidator ensures added cards are validated, also ensure people can't leave fields empty

Refund page doesn't function

The title explains itself

Adding cards is pointless

Cards don't need to be added to the session, the form should only keep the card for the request. This also means that the card and transaction form can be merged in the future, making it easier for customers to perform operations (first checks form fields, then checks card with card checker, then uses ReST once it knows everything the user entered is validated).

The refund form on the admin page will work similarly to this, but only has customer card number and amount as fields (form only shows if there's currently an admin card in properties).

Lack of Bootstrap

Most of the layout is currently done in raw CSS, convert it to Bootstrap so it functions better.

This will be particularly useful for working on the fancier designs in phase 2 and phase 3.

Currently no documentation

Self explanatory, the documentation needs to be worked on.

Automatic logging in causes an error when properties from another group already exists

After assignment is marked, this can be fixed.

Cards require muliple lines of code to setup

It would be better for it to be initialised with the attributes instead of using setters.

Lack of custom tests and logs

More tests and logs are always good!