wrlc / alma-fines Goto Github PK

We need to verify that the fee owner is the actual owner if the item, not the scf IZ.

depends on #20

instead of selecting iz to look for fines in, search them all by default.

replace ALMA_INSTANCES with ALMA_INSTANCES_NEW format.

show_fines() should omit the user's home IZ when searching for fines (fines like that should never be paid through this app).

List all data that needs to go into the alma transaction to create a reconciliation report below.

Don't say Bender library, say "american university"

use printable area html to keep it simple for now. Could generate a pdf in future.

how to configure, run

May require changes to token issued at aladin-sp ... /issue.php

save in session?

• Remove basic auth front gate
• Restrict access to backdoor to HQ
• Review templates, remove prototype references, look for typos
• Change 'wrlcfinesapp' comment tag to something prod/test configurable
• Move audit log to log sub-directory (in settings?)
• options for hard-coded login URL? or hairpin fines.wrlc.org?
• use a random string for the SHARED_SECRET (change in Aladin-SP/auth/issue.php also)

Shouldn't happen, but I managed to create one for myself on accident. Maybe just filter and don't display if balance is negative?

Use gnunicorn or similar to run this app (nginx as proxy for production).

Should not be able to submit form w/lending + home library the same (that kind of find should never be handled in this app).

Amounts should be formatted as $1.00 instead of 1.0.

Use aiohttp library instead of requests. It's performing OK now, but will be very slow when searching all 14 IZs

resources:

AIOHTTP docs: https://docs.aiohttp.org/en/stable/index.html
example: https://terriblecode.com/blog/asynchronous-http-requests-in-python/

Write an "alma request" function to make all calls that returns a standard response on failure thats more useable than just 400. (include message).

requested by @dongourley

Add textarea to each fee row pre-populated with total amount. Users can change the amount before submitting. Frontend.js will check this field when building payment queue. Also will need validation. Value must be between 0 and the total balance. (no overpaying or invalid amounts like negative numbers).

So this can be more easily used by other consortia, need to be able to define the institutions in the consortium (currently hard-coded in templates/login.html) and the URL to send the user to login (currently hard-coded in static/js/frontend.js) to settings.py.

Also, need a setting in settings.py to turn on and off the backdoor login that is defined in fines_app.py.

Update README.md when these settings are implemented.