wreis / dbix-class-parseerror

Extensible database error handler

Hi there 👋

I am a software engineer with Bachelor's degree in Computer Science. I've already worked on applications in different data domains, and with main experience in web development, QA and operations.

I am a contributor of open source software projects.

More about me at http://wallace.reis.me/

dbix-class-parseerror's Issues

Can't parse errors when using DBIx::Class quote_char

When using Schema->connect($dsn, $user, $pass, { quote_char => '`' }
(https://metacpan.org/pod/DBIx::Class::Storage::DBI#quote_char), DBIx::Class::ParseError is not capable of parsing the exception:

For a duplicate entry I get:

Parsing error string failed at local/lib/perl5/DBIx/Class/ParseError/Parser.pm line 251.
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry 'table' for key 'name' [for Statement "INSERT INTO `table` ( `name`) VALUES ( ? )" with ParamValues: 0='value1'] at lib/Module.pm line 91

When I connect without quote_char, DBIx::Class::ParseError can parse the exceptions.

Type in documentation: "the exception will like not have"

the exception will like not have additional information beyond the error message and the error message.

Should that be "the exception will not have" or "the exception will likely not have"?

ParseError dies when it can't parse an error

Hi,

I was wondering what you would think about changing a bit the behavior of this module. When the error from DBI cannot be parsed, it throws an exception. https://github.com/wreis/DBIx-Class-ParseError/blob/master/lib/DBIx/Class/ParseError/Parser.pm#L250.

Since the module is already used in exception handlers, It would be nice that it returned an exception object even if it couldn't parse the message, making the exception handling code simpler.

Would you be interested in a patch in this direction?