Comments (2)
This was changed due to an issue with JS errors on frontend for some users if the jquery wasn't used. I think two parts need to happen here. I think I need to refactor the jQuery out and secondly open the regex to additional areas of the admin panel
from oembed.
That doesn't really make sense though because the getIsCpRequest()
check already excludes the frontend. I dug through the old issues and found issue #12 which seems to be the motivation for the regex.
The original problem is about the <script>
tag being included in a JSON result. Only including assets in certain control panel areas isn't really the best fix for that. The assets should be included in all full page HTML results - or ideally only when the field itself is rendered as well.
Fortunately this is actually pretty easy to do. I've created a PR (#63) that should solve this issue along with #52.
from oembed.
Related Issues (20)
- Serialization of 'DOMDocument' is not allowed HOT 14
- FallbackAdapter is not handled correctly due to #101 fix HOT 5
- Loss of metadata when loading from cache on 2.2.x HOT 2
- Youtube embed stopped working HOT 7
- Error when using entry.field.media.image HOT 15
- oEmbed Stopped Pulling Data HOT 5
- Broken URL notifications not working on Craft 4 HOT 3
- Craft 4 embeds suddenly default to 200px wide iframe HOT 10
- Spotify embeds are only working in local environment HOT 1
- "Please check your URL" bug is back? HOT 20
- Cache tweets HOT 2
- Further changes required for GDPR compliance HOT 4
- Video preview very small HOT 2
- Division by zero error in both backend and frontend HOT 4
- ignores time #t=1m12s HOT 4
- Vimeo URLs not working (when video is set to be hidden on Vimeo.com) HOT 1
- Field always renders as if it has content HOT 2
- Field causes template to crash if left blank HOT 3
- Issue when using oEmbed in Vizy block HOT 3
- v3 does not return `.images` and other API data HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oembed.