Coder Social home page Coder Social logo

Comments (4)

reganlawton avatar reganlawton commented on September 1, 2024 2

Updated v3.0.3 with new changes with a new setting to support.

from oembed.

iparr avatar iparr commented on September 1, 2024

I first raised a request concerning this, perhaps without giving full consideration to GDPR requirements: #23

What I think I'd like to see is:

  1. Interface / documentation language changed so that people don't think they're automatically compliant (I will try and find time for a pull request). I still see some value to this plugin setting as it is now.
  2. A solution like yours @joepagan - to enhance this and help people towards full GDPR compliance. I wonder what other approaches there are?

from oembed.

reganlawton avatar reganlawton commented on September 1, 2024

Hmm interesting, so @joepagan and @iparr we'd need something like:

$iframe = $dom->getElementsByTagName('iframe')->item(0);
$src = $iframe->getAttribute('src');

$src = $this->manageGDPR($src);

if (Oembed::getInstance()->getSettings()->enableGdpr) {
    $iframe->setAttribute('data-cookieblock-src', $src);
    $iframe->setAttribute('data-cookieconsent', 'marketing');
}

I do a ton of backend the past year or two, ML stuff, so don't follow GDPR much.

from oembed.

paulwaddington avatar paulwaddington commented on September 1, 2024

It looks like this update will set 'data-cookieblock-src' in addition to the 'src' attribute, though the Cookiebot implementation removes the 'src' attribute.

It would be great if we could also display a placeholder before or after the iframe-tag

<div class="cookieconsent-optout-marketing">
    Please
    <a href="javascript:Cookiebot.renew()">accept marketing-cookies</a>
    to watch this video.
</div> 

This is the original Cookiebot page:

https://support.cookiebot.com/hc/en-us/articles/360003790854-Iframe-cookie-consent-with-YouTube-example

from oembed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.