Comments (4)
Updated v3.0.3 with new changes with a new setting to support.
from oembed.
I first raised a request concerning this, perhaps without giving full consideration to GDPR requirements: #23
What I think I'd like to see is:
- Interface / documentation language changed so that people don't think they're automatically compliant (I will try and find time for a pull request). I still see some value to this plugin setting as it is now.
- A solution like yours @joepagan - to enhance this and help people towards full GDPR compliance. I wonder what other approaches there are?
from oembed.
Hmm interesting, so @joepagan and @iparr we'd need something like:
$iframe = $dom->getElementsByTagName('iframe')->item(0);
$src = $iframe->getAttribute('src');
$src = $this->manageGDPR($src);
if (Oembed::getInstance()->getSettings()->enableGdpr) {
$iframe->setAttribute('data-cookieblock-src', $src);
$iframe->setAttribute('data-cookieconsent', 'marketing');
}
I do a ton of backend the past year or two, ML stuff, so don't follow GDPR much.
from oembed.
It looks like this update will set 'data-cookieblock-src' in addition to the 'src' attribute, though the Cookiebot implementation removes the 'src' attribute.
It would be great if we could also display a placeholder before or after the iframe-tag
<div class="cookieconsent-optout-marketing">
Please
<a href="javascript:Cookiebot.renew()">accept marketing-cookies</a>
to watch this video.
</div>
This is the original Cookiebot page:
from oembed.
Related Issues (20)
- Cache tweets HOT 2
- Video preview very small HOT 2
- Division by zero error in both backend and frontend HOT 4
- ignores time #t=1m12s HOT 4
- Vimeo URLs not working (when video is set to be hidden on Vimeo.com) HOT 1
- Field always renders as if it has content HOT 2
- Field causes template to crash if left blank HOT 3
- Issue when using oEmbed in Vizy block HOT 3
- v3 does not return `.images` and other API data HOT 10
- Additional data missing for media objects HOT 11
- How do we get the media data with the new update? HOT 7
- Looping a video HOT 6
- YT/Vimeo media URL blank after upgrading to 3.x HOT 3
- Google Maps Error: www.google.com refused to connect HOT 1
- Large quantities of embed-cookies-{uid} are being created, but not deleted? HOT 1
- possible to display Youtube thumbnail before user gives cookie consent? HOT 2
- Vimeo URLs not working in any environment HOT 28
- GrapQL - Error when querying an entry with a empty oEmbed URL
- oEmebed resources not loaded in Craft Cloud environment HOT 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oembed.